-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate biginitial style #632
Comments
Since I'm the one that raised this issue, allow me to write my "manifesto" of where I see this going: Deciding what kind of initial to have accompany a score is, in my mind, a typesetting decision, not a score representation one, and thus should be in the TeX and not the gabc. I would thus like to see the In it's place, I'd introduce a There would then be just one set of initial related parameters: I would then add an example which demonstrates how to set up some "master commands" which can allow the user to quickly switch between different initial settings in a project where it is necessary to switch back and forth between various sized initials. I would not include such commands in the package. |
I agree with this on a philosophical level (which is why I closed out my pull request). However, there is a technical issue in that center determination on the first syllable changes depending on whether or not there is an initial. Perhaps the first syllable could use a different macro to indicate the two different "centerings", which would result in four centerings:
|
I agree with the general idea, including the new centering proposed by @henryso I just think maybe we should leave it for 4.1? |
This is definitely something I would leave for 4.1. A different macro for the first syllable is, I think, almost a necessity at this point. We're already disecting it six-ways from Sunday in order to do the styling that @henryso introduced and this will just make things worse. As I see it, the first syllable needs to have the following parts identified:
4 & 5 are different when the syllable starts with a consonant; 6 and 7 are different when the syllable starts with a vowel. I've assumed that the initial is never in the last part of the syllable. There might be a way to extract 5 & 7 from 4 & 6 using 1 and some of Though, with a different command for the first syllable than for all the rest, we may not need to put styling commands explicitly in the gtex file and can instead apply them completely internally. That might make the string manipulation of the first syllable possible. |
People will always find a way to do some weird styling, special characters, and texverbs, so I think it's better to just divide in up into the pieces you mentioned rather than manipulate in it TeX. |
@rpspringuel, how should I deal with user-specified styling of the first letter of the score? Should I provide styled and unstyled versions? |
I'm not sure what you mean. Do you mean a first syllable which is styled with tags in gabc ( |
Yes, that's what I mean. |
I should think that tags in the gabc should be generally ignored in the first word because of the existence of the appropriate styles in the TeX ( Is there a situation where one would want the tags to apply despite the styles? Or some situations where the tags allow something the styles don't? |
We could ignore styles, but people seem to do very "interesting" things with that first syllable, and this would be surprising behavior. I'm willing to bet that someone's going to want to do something unusual like make all e's in the score red. |
In that case I would pass the tags as they are entered in the gabc and let the user sort out the interactions manually. |
Ok, so by example, let's say the first syllable is
Does that congrue with what you are thinking? |
Yes. That concurs with my thought. |
Not 4.1? |
I marked it as 5.0 rather than 4.1 because it requires a user interface change (we'll be deprecating commands that are specific to the big initial). I expect it will appear in 4.1, but then the next release will have to be 5.0, not 4.2. Putting the 5.0 milestone on it was my way of noting that (admittedly, it's not a very clear way of doing so). |
Is the intent to have the initial-style gabc header be transferred like the annotation headers or is the initial-style header to be deprecated? |
@rpspringuel Did you have any thoughts on this? |
Part of the implementation for gregorio-project#632.
Part of the implementation for gregorio-project#632.
An additional question: Is the desired end result to have two states: initial and no-initial, or three: normal-initial, big-initial, and no-initial? I cannot proceed much further with the implementation (which you can see in my fork as fix-632) unless I know the answer to this and my previous question. |
Sorry, been a bit busy this past week. My idea was that the The |
That scheme makes sense to me. However, I would propose a macro name that indicates that it is concerned with the line height and not font size. |
How about |
You know, I almost put that down in my previous post and then realized that I has used |
Corresponds with changes for gregorio-project/gregorio#632.
Part of the implementation for gregorio-project#632.
How would I deprecate |
Part of the implementation for gregorio-project#632.
Part of the implementation for gregorio-project#632.
Corresponds with changes for gregorio-project/gregorio#632.
I would add something like the following to
This way if the user tries to change the big initial style they get warned about it. Off the top of my head, I can't think of a way of warning those who were happy with the defaults, but I think about it some more and see if I can't come up with something. |
Should I create a branch off develop in the main repository to collaborate? |
I don't think that's necessary at this point. I'm busy with a paper for probably the next week and won't have time to do any work, just to suggest ideas. Speaking of which, here's the brainstorm I had today. Like the Since the elimination of the To maintain backwards compatibility, something like what you did for the |
I didn't think about that angle. I'll give it a shot. |
By the way, we don't have to make the command line tool error out in that way. The command line tool typically emits something deprecated when a deprecated feature is used. This is easily trapped in TeX, so the stop/continue behavior can live wholly in TeX. That's how I implemented the |
I agree that the behavior can be completely controlled in TeX. However, I still think it might be a good idea if the command-line tool had the capability of erroring out in the event of a deprecation. If it did this, then I could conceive of writing a shell script which could check every gabc file in a large file, looking for the file which need to be updated. Actually, now that I think about it, this might be a better accomplished with the gabc-to-gabc functionality of the command-line tool. The command-line tool obviously shouldn't output any deprected headers when writing a gabc file, so by passing it over all the gabc files with the |
OK, but I think that's better handled as a separate issue. |
Agreed. |
Well, let me qualify that. In so much as your works deprecates the |
Understood. It already behaves that way for |
Part of the implementation for gregorio-project#632.
Part of the implementation for gregorio-project#632.
Part of the implementation for gregorio-project#632.
…he log. Fixed missing "else" case in IfStrEq. Part of the implementation for gregorio-project#632.
Part of the implementation for gregorio-project#632.
* develop: Addeds test and expectations for note-in-same-glyph episema height fix. Tests the fix for gregorio-project/gregorio#693. Updated expectations to match the fix for gregorio-project/gregorio#675. Added gabc-to-gabc tests and expectations. Added support for gabc-to-gabc tests. Updated expectations to match changes for gregorio-project/gregorio#670. Updated test for biginitial style deprecation. Corresponds with changes for gregorio-project/gregorio#632. Updated tests and expectations for initial-style deprecation. Corresponds with changes for gregorio-project/gregorio#632. Added support for per-gabc-output-test preamble files. Updated expectations to match changes for gregorio-project/gregorio#632. Added a test for the forced initial hyphen. Corresponds with gregorio-project/gregorio#656. Tests the fix for gregorio-project/gregorio#653. Added tests and expectations corresponding to gregorio-project/gregorio#636. This tests the implementation of gregorio-project/gregorio#631.
* develop: Adding Known Bugs to CHANGELOG Making Release Called gregorio_strdup instead of strdup. Applied fixes suggested by Karl Berry for integration into TeX Live. Fixed incorrect detection of note-in-same-glyph for episema height adjustment. Fixes gregorio-project#693. Spelling error in CHANGELOG Typo in example Corrected end-of-word detection when there is no whitespace at end-of-file. Fixes gregorio-project#675. Improved the display of enum values in gabc output error messages. Modified gabc and dump writers to write only non-deprecated headers. Fixes gregorio-project#670. Corrected markdown formatting. Part of the implementation for gregorio-project#632. Added \MessageBreak to break up the long message for readability in the log. Fixed missing "else" case in IfStrEq. Part of the implementation for gregorio-project#632. Added change log and upgrade documentation for this change. Part of the implementation for gregorio-project#632. Deprecated \gre@style@biginitial. Part of the implementation for gregorio-project#632. Added change log with link to gregorio-project#631. Deprecated gabc initial-style header. Part of the implementation for gregorio-project#632. Documented new and renamed macros. Part of the implementation for gregorio-project#632. Refactored first syllable output to allow TeX-controlled initial style. Part of the implementation for gregorio-project#632. Corrected escape of hash sign in documentation. Implemented salicus flexus glyphs. Fixes gregorio-project#631.
This discussion began in #630. Please continue the discussion here.
The text was updated successfully, but these errors were encountered: