Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added biginitialraise dimension to allow a separate shift for big initials. #630

Closed
wants to merge 1 commit into from

Conversation

henryso
Copy link
Contributor

@henryso henryso commented Oct 1, 2015

Since you can style initials separately from big initials, I think the same should be true for the shift.

All the tests pass.

Please review and merge if acceptable.

@henryso henryso added this to the 4.0 milestone Oct 1, 2015
@eroux
Copy link
Contributor

eroux commented Oct 1, 2015

ok for me

@rpspringuel
Copy link
Contributor

I don't like this because it really can lead to a huge proliferation of stuff. If big initials get their own initialraise, shouldn't they also get their own manualinitialwidth, beforeinitialshift, and afterinitialshift? Personally I'd be in favor of going in the other direction and collapsing the separate styles rather than proliferating the amount of stuff associated with the initials.

Of course, this is at least in part due to a request that Br. Innocent mentioned to me in person once, but which I've yet to take any action on (or even mention, come to think about it): the ability to have 3 and 4 line initials. If we follow the pattern of having separate variables/styles for each size then implementing this new feature will mean 4 sets of them. That strikes me as a bit excessive.

@henryso
Copy link
Contributor Author

henryso commented Oct 1, 2015

Ok, let's talk about collapsing the styles. How you would envision doing that?

@rpspringuel
Copy link
Contributor

I would have just one style: initial This would be used for all initials, regardless of size. By default, we'd probably size it for a 1-line initial, but the user would be free (and indeed expected) to redefine it when the score they're working with has a two-line (or more, if we ever get there) initial.

Implementation wise, in the immediate term I'd simply replace instances of \gre@style@biginital by \gre@style@initial in the code (likewise for \endgre...), I'd remove biginitial from the list of defined styles, and I'd add a conditional to \grechangestyle which checks to see if the user is attempting to modify biginitial and if so emit a deprecation warning while redirecting the modification to initial.

I might also include an extra warning in the code which prints a big initial which lets users who might have been satisfied with the defaults (and thus not making changes to biginitial) know about the change.

Along similar lines, I'd like the transition between the various sizes of initials to be in the TeX rather than the gabc, much like we migrated the lyric centering decision, and for GregorioTeX to be able to automatically break lines when the initial is 2 (or more) lines large. However, I realize that this aspect would be a much bigger undertaking (lots more interacting parts to deal with) and would willingly see it set aside as beyond the scope of this particular change.

@henryso
Copy link
Contributor Author

henryso commented Oct 1, 2015

Would we also eliminate gabc's initial-style: 2?

@henryso henryso removed this from the 4.0 milestone Oct 1, 2015
@henryso henryso closed this Oct 1, 2015
@henryso henryso deleted the biginitialraise branch October 1, 2015 21:22
@henryso
Copy link
Contributor Author

henryso commented Oct 1, 2015

Please continue this discussion in #632.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants