Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Long project names are cut of which makes them hard to tell apart #5122

Closed
csweichel opened this issue Aug 9, 2021 · 9 comments · Fixed by #5323
Closed

[dashboard] Long project names are cut of which makes them hard to tell apart #5122

csweichel opened this issue Aug 9, 2021 · 9 comments · Fixed by #5323
Assignees
Labels

Comments

@csweichel
Copy link
Contributor

When opening a long repo name, e.g. github.com/some-long-org/business-unit-and-department the context on the dashboard is cut of and it's very hard to tell workspaces apart.

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 9, 2021

Thanks for opening this @csweichel! The pain point described in this issue could be resolved once we ship Teams & Projects and properly surface workspaces under each team (see #4921).

The end goal is to have workspaces under personal account with links to personal projects if they exist (see #5125) and group all workspaces under each team for all associated projects under a team.

Workspaces (Personal Account) Workspaces (Team)
Personal Personal-1

🍊 🍊 🍊 🍊

@corneliusludmann did experiment with adding tooltips on all elements before but we voted against it in #4416 (comment). However, we could consider temporarily adding a single tooltip or a title attribute on the repository element if it helps.

🍋 🍋 🍋 🍋

Also, FWIW, there's #3594 which could improve the information parsing on the workspace list.

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 10, 2021

Alternatively, using better truncation, by truncating the middle part would also work and would be more preferable maybe as it would introduce a change we can leave there without the need to remove later. 💡

For example, showing: github.com/som…department instead of github.com/some-long-org/….

See relevant discussion (internal).

@adam-tylr
Copy link

My company has some project names well over 100 characters. I like the truncation idea. Maybe showing the full path on a tooltip or something if you mouse over. We have a few repos that might have the same name but live in a different business unit's folder for example. That would let us verify the whole path if we needed to.

@svenefftinge
Copy link
Member

svenefftinge commented Aug 12, 2021

We should cut off the github/gitlab bit (people know where their repos sit) so it renders as org/repo. With projects (coming soon) we will also show it as team/project which is the same pattern GitHub and GitLab use on their sites.
I think truncating in the middle would be a little strange/special, but providing tooltips makes a ton of sense.

@JanKoehnlein
Copy link
Contributor

/schedule

@corneliusludmann
Copy link
Contributor

We should cut off the github/gitlab bit (people know where their repos sit) so it renders as org/repo.

What about replacing github.com / gitlab.com / bitbucket.org with their logos? Since I use both, GitHub and GitLab repo, it would help me to spot the right repo. And a small icon would not take that much space.

@JanKoehnlein
Copy link
Contributor

/assign @laushinka

@gtsiolis gtsiolis added the feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. label Aug 20, 2021
@laushinka
Copy link
Contributor

Discussed this with @gtsiolis and decided to add a tooltip as a temporary solution to this issue until we launch Teams and Projects.

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 23, 2021

Thanks @laushinka, adding below some more discussion points for transparency:

  1. Replacing the provider domain name with an icon as described in [dashboard] Long project names are cut of which makes them hard to tell apart #5122 (comment) could help but I'd suggest to be frugal with adding more icons when possible. Besides this, using the provider icon would work only as a provider type indicator as the domain could be different for self hosted providers which could be fine!
  2. Removing the provider domain name as described in [dashboard] Long project names are cut of which makes them hard to tell apart #5122 (comment), could resolve the issue for most cases but could still keep the project hidden. FYI, GitLab supports up to 20 levels of subgroups.
  3. Adding a tooltip seems like a good boring (simple) solution forward, in the context of this issue, which is also a two-way door decision as we could easily revert this with little to zero impact in the future.
  4. Middle truncation may seem a little bit strange but possibly is the best solution in the long run as this would be also needed for the tooltip content when the path is really long due to size contraints we may enforce for the tooltip component.

@gtsiolis gtsiolis linked a pull request Aug 23, 2021 that will close this issue
@gtsiolis gtsiolis removed the feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. label Aug 23, 2021
@JanKoehnlein JanKoehnlein added the team: webapp Issue belongs to the WebApp team label Aug 24, 2021
laushinka added a commit that referenced this issue Aug 24, 2021
roboquat pushed a commit that referenced this issue Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants