Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the context column information #3594

Open
gtsiolis opened this issue Mar 25, 2021 · 5 comments
Open

Improve the context column information #3594

gtsiolis opened this issue Mar 25, 2021 · 5 comments
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 25, 2021

Problem to solve

The design specs in #3426 for the new Workspaces list contained some structure and labels for the Context URL. For the time being, we're surfacing the context URl which overflows on smaller viewports and includes some duplicate information with the Pending Changes column on the right.

Proposal

More particularly, on the second column, a) the context URL should not include the branch name, b) the context URL should surface the commit message, and c) the subtitle should be more semantic like Pull Request 324,.

Designs

Attaching below an early design spec for this proposal, see Context column. /cc @svenefftinge

BEOFRE AFTER
Workspaces (List) - BEFORE Workspaces (List) - AFTER
@gtsiolis gtsiolis added this to the March 2021 milestone Mar 25, 2021
@apolopena
Copy link

Would the branch information then go into the name column? I was not seeing the branch information anywhere but the context column in the V2 design
The icons are helpful in the V1 design, maybe they can stay in V2 somehow?
image

@svenefftinge
Copy link
Member

I'm not sure I understand what's being discussed here, but #3627 might improve the situation by making the context url an actual link. With that you can go to the context or copy the url.

@apolopena
Copy link

apolopena commented Mar 28, 2021

@svenefftinge
Yes #3627 does help. I was discussing placement of the data in regard to the context URL and not loosing any visual cues in the redesign that would inform the user as to what data they are actually looking at.

Regarding the redesign
The new design does away with the icons and has less space to display the data but being compact is good thing so:

For Clarity

  • Could the full urls in a 'cell' be displayed in a tool tip when rolling over a link?

    • Without the icons and with the urls being truncatated, it can be unclear what the urls are for.

For Consistency and functionality

  • Cells in the Name column have two parts (workspace URL, repo URL), each are links. This is good UI.
  • Context cells have two parts as well (branch URL and I am not sure what the lower link is for), however the top part (branch URL) is not a link.
    • Could both parts in a Context 'cell' be a link?

@svenefftinge svenefftinge modified the milestones: March 2021, April 2021 Apr 12, 2021
@gtsiolis gtsiolis added type: improvement Improves an existing feature or existing code and removed needs visual design roadmap item: new dashboard priority: 💪 stretch goal This issue is a stretch goal within an iteration. labels Apr 15, 2021
@gtsiolis gtsiolis changed the title [dashboard] Replace context URLs and labels [dashboard] Improve the context column information Apr 15, 2021
@csweichel csweichel removed this from the April 2021 milestone May 6, 2021
@stale
Copy link

stale bot commented Aug 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 4, 2021
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Aug 4, 2021
@gtsiolis gtsiolis added the team: webapp Issue belongs to the WebApp team label Nov 25, 2021
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 7, 2022

What do you think of this feature request, @jldec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience
Projects
None yet
Development

No branches or pull requests

4 participants