-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zcash integration #7487
Merged
Merged
zcash integration #7487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
force-pushed
the
zcash
branch
4 times, most recently
from
September 22, 2020 08:00
f736ac3
to
308023a
Compare
Merged
thelostone-mc
force-pushed
the
zcash
branch
3 times, most recently
from
September 28, 2020 05:24
bff0faa
to
0d3f777
Compare
- migrate new to vue + add zcash support - update details view - backend wiring
If all contributions are successfulResponse
If mandatory param is missing in any of themResponse
If a 500 happens while processing 1 contributionResponse
|
- ensure contirbution mail is sent only after txn is validated - removed address as a mandatory param on the backend - set deploy_tx_id default to 0x0
ZCash-Ethereum cart fixes
octavioamu
requested review from
danlipert,
frankchen07,
octavioamu and
PixelantDesign
as code owners
October 21, 2020 23:21
octavioamu
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Endpoint:
POST
localhost:8000/grants/v1/api/contribute
Refers/Fixes
Note
TokenName: ZEC
Decimals: 8
ChainId: (NA ?)
Address: (NA ?)
BUGS
Pending