chore: backend fixes #7725
chore: backend fixes #7725
Conversation
- ensure contirbution mail is sent only after txn is validated - removed address as a mandatory param on the backend - set deploy_tx_id default to 0x0
thelostone-mc
requested review from
danlipert,
frankchen07,
octavioamu and
PixelantDesign
as code owners
| @@ -1173,7 +1173,8 @@ def create_contribution(self, tx_id): | |||
| self.save() | |||
| grant.updateActiveSubscriptions() | |||
| grant.save() | |||
| successful_contribution(self.grant, self, contribution) | |||
There was a problem hiding this comment.
@mds1 / @octavioamu this is what always causes the mail to be sent asap !
For cross chain flows it will happen only after txn is validated
For eth -> we will have to shift this to the celery task which does the validation
process_grant_contribution can do this in follow up PR after running it with team
| @@ -73,6 +77,19 @@ def get_zcash_txn_status(txnid): | |||
| return None | |||
|
|
|||
|
|
|||
| def is_txn_done_recently(time_of_txn): | |||
There was a problem hiding this comment.
this check ensures that the txn was signed within 5 hours of submission on the Contribution record being created
| 'message': 'error: tx_id is mandatory param' | ||
| }) | ||
| continue | ||
| # tx_id = contribution.get('tx_id', None) |
There was a problem hiding this comment.
made this not mandatory as other cross chains might not be able to provide tx_id , commented out in case if want to keep this for some reason
There was a problem hiding this comment.
Good call - do you want to add a quick comment in the code explaining it?
There was a problem hiding this comment.
will add it in a follow up commit 🙌
Description