Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZCash-Ethereum cart fixes #7718

Merged
merged 2 commits into from
Oct 21, 2020
Merged

ZCash-Ethereum cart fixes #7718

merged 2 commits into from
Oct 21, 2020

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Oct 20, 2020

  • Ethereum standard checkout works successfully
  • zkSync checkout needs to be tested
  • Donation summaries in Ethereum tab are correct

@mds1 mds1 mentioned this pull request Oct 20, 2020
Closed
@mds1 mds1 marked this pull request as ready for review October 20, 2020 21:17
@mds1
Copy link
Contributor Author

mds1 commented Oct 20, 2020

@thelostone-mc @octavioamu Ready for review

@octavioamu octavioamu merged commit d2afd1d into gitcoinco:zcash Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@octavioamu octavioamu octavioamu approved these changes

@danlipert danlipert Awaiting requested review from danlipert

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mds1 @octavioamu @thelostone-mc