Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating styles for new issue form to make it more responsive. #690

Closed
wants to merge 138 commits into from
Closed

Updating styles for new issue form to make it more responsive. #690

wants to merge 138 commits into from

Conversation

joshmobley
Copy link
Contributor

Fixes: #679

Description

Updates to responsive styles for new issue form.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UI for new issue form

Testing

Tested these changes in a responsive emulator. Also checked codebase for any scoping issues and found none.

Refers/Fixes

Fiexes: #679

@mbeacom mbeacom added enhancement This is a feature to be enhanced or improved. needs-testing frontend This needs frontend expertise. labels Mar 23, 2018
@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #690 into master will decrease coverage by 0.52%.
The diff coverage is 27.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
- Coverage   34.92%   34.39%   -0.53%     
==========================================
  Files          97      101       +4     
  Lines        5286     5594     +308     
  Branches      591      648      +57     
==========================================
+ Hits         1846     1924      +78     
- Misses       3372     3596     +224     
- Partials       68       74       +6
Impacted Files Coverage Δ
app/dashboard/embed.py 6.22% <ø> (ø) ⬆️
app/app/sitemaps.py 72.5% <ø> (ø) ⬆️
app/app/urls.py 100% <ø> (ø) ⬆️
...ernal_bounties/management/commands/sync_gitcoin.py 0% <0%> (ø)
...pp/economy/management/commands/refresh_bounties.py 0% <0%> (ø) ⬆️
...eting/management/commands/bounty_feedback_email.py 0% <0%> (ø) ⬆️
app/marketing/management/commands/pull_stats.py 0% <0%> (ø) ⬆️
...pp/marketing/management/commands/remarket_tweet.py 66.66% <0%> (ø) ⬆️
app/gitcoinbot/views.py 34.61% <0%> (-1.39%) ⬇️
.../dashboard/management/commands/cleanup_db_space.py 0% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a5e22...096b422. Read the comment docs.

@mbeacom mbeacom added the mobile label Mar 23, 2018
@PixelantDesign
Copy link
Contributor

@thelostone-mc do we still need to do this?

@mbeacom
Copy link
Contributor

mbeacom commented Mar 28, 2018

@PixelantDesign Yes, I believe we still need this PR.

The current view on live while browsing from mobile:

screenshot 2018-03-28 13 59 50

@KennethAshley
Copy link
Contributor

Oh man. You might want to rebase this instead of merge!

@joshmobley
Copy link
Contributor Author

@KennethAshley that's what i thought i had done -- obviously borked it -- will fix this

@KennethAshley
Copy link
Contributor

No problem. Just saw this in passing! Good work!

@joshmobley joshmobley closed this Mar 28, 2018
@thelostone-mc
Copy link
Member

@PixelantDesign Ah I had taken care of that way back before the forms had been replaced with the newer ones ! Must have been missed whenever this page was updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature to be enhanced or improved. frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitcoin.co/new issue page not responsive
10 participants