Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#679 - new issue responsive updates #735

Merged
merged 2 commits into from
Apr 2, 2018
Merged

#679 - new issue responsive updates #735

merged 2 commits into from
Apr 2, 2018

Conversation

joshmobley
Copy link
Contributor

Description

Updates to responsive styles for new issue form.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UI for new issue form

Testing

Tested these changes in a responsive emulator. Also checked codebase for any scoping issues and found none.

Refers/Fixes

Fixes: #679

@joshmobley
Copy link
Contributor Author

updated PR from #690 -- had borked the rebase

@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   34.39%   34.39%           
=======================================
  Files         101      101           
  Lines        5594     5594           
  Branches      648      648           
=======================================
  Hits         1924     1924           
  Misses       3596     3596           
  Partials       74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1271188...ae981e4. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm - Needs review by design.

@mbeacom mbeacom added the frontend This needs frontend expertise. label Mar 29, 2018
@PixelantDesign
Copy link
Contributor

@joshmobley what was the update here?

@joshmobley
Copy link
Contributor Author

image
image
image

All tweaks for smaller sizes:

  • reflowing the dropdowns to a column
  • tweaking the way the tabs work so they don't reflow
  • generally fitting the form to use more screen real estate

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@mbeacom mbeacom merged commit 2dd9a3f into gitcoinco:master Apr 2, 2018
@joshmobley joshmobley deleted the 679-new-issue branch April 2, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitcoin.co/new issue page not responsive
4 participants