Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize images in assets #724

Merged
merged 4 commits into from
Mar 28, 2018
Merged

Optimize images in assets #724

merged 4 commits into from
Mar 28, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Mar 27, 2018

Description

The goal of this PR is to optimize all images in app/assets/* and provide a quick stopgap bash script scripts/compress_images.bash - (make compress-images) to optimize/compress/squash all svg, png, and jpg files throughout the assets directory until we implement some runner to take over during bundling.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

static

Refers/Fixes

Ref #608

@mbeacom mbeacom requested a review from owocki March 27, 2018 20:57
@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   34.79%   34.79%           
=======================================
  Files          99       99           
  Lines        5536     5536           
  Branches      642      642           
=======================================
  Hits         1926     1926           
  Misses       3536     3536           
  Partials       74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41069d...4ec0856. Read the comment docs.

@mbeacom mbeacom merged commit 9fe60a9 into master Mar 28, 2018
@mbeacom mbeacom deleted the optimize-imgs branch March 28, 2018 14:52
@mbeacom
Copy link
Contributor Author

mbeacom commented Mar 28, 2018

Before:
home_desktop

After:
home_desktop_after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants