Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theming): dark mode 🌚 #6258

Merged
merged 10 commits into from
Apr 29, 2020
Merged

Conversation

kelonye
Copy link
Contributor

@kelonye kelonye commented Mar 20, 2020

Screenshot 2020-03-20 at 04 49 36

Screenshot 2020-03-20 at 04 49 31

Also see demo video

Description
Todos
  • Auto system dark/light mode detection
  • Enable explicitly setting mode via switcher; persisted to localstorage/cookie
Refers/Fixes

Gitcoin bounty

Testing

Work in progress...

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #6258 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6258      +/-   ##
==========================================
+ Coverage   28.24%   28.26%   +0.02%     
==========================================
  Files         278      278              
  Lines       25403    25403              
  Branches     3718     3718              
==========================================
+ Hits         7175     7181       +6     
+ Misses      17947    17941       -6     
  Partials      281      281
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ab7b5...cc3bd44. Read the comment docs.

@walidmujahid
Copy link
Contributor

#6245

@kelonye
Copy link
Contributor Author

kelonye commented Mar 21, 2020

Light Dark
Screenshot 2020-03-21 at 04 26 45 Screenshot 2020-03-21 at 04 26 42

@kelonye kelonye changed the title Dark mode 🌚 feat(theming): dark mode 🌚 Mar 23, 2020
@octavioamu
Copy link
Contributor

@willsputra @PixelantDesign for the feature review

@kelonye
Copy link
Contributor Author

kelonye commented Apr 22, 2020

Looks like a lot of heat at #6245. I guess we can close this :).

@thelostone-mc thelostone-mc merged commit 1289b0b into gitcoinco:master Apr 29, 2020
@danlipert
Copy link
Contributor

@vbstreetz really nice work on this - do you have any interest in building upon this work and extending dark mode across the site? Let me know CC: @owocki

@kelonye
Copy link
Contributor Author

kelonye commented Apr 29, 2020

@danlipert Sure! When can I resume? 😎

@owocki
Copy link
Contributor

owocki commented Apr 29, 2020

@vbstreetz i just created this github issue for you. #6530

would love to throw a couple ETH in that. how big/complex do you think itll be?

@octavioamu
Copy link
Contributor

@vbstreetz there where some missing components styles so I decided to fix it since was a blocker for deploy and also to fit the design proposed. Please take a look on the PR #6531

@kelonye
Copy link
Contributor Author

kelonye commented Apr 30, 2020

Hey! I see @octavioamu made some big progress 😎... i'll check it out more soon.

@owocki Cool! Though hard to tell an exact estimate but am def available for 2 weeks from 18th (work vacation) if its not too far? (sorry, i should have hinted this earlier).

@owocki
Copy link
Contributor

owocki commented Apr 30, 2020

checkout what @octavioamu did. if we do more bounties, would love to have the PRs submitted with the same style/level of quality that it was after both you/octavio had a pass at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants