-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theming): dark mode 🌚 #6258
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6258 +/- ##
==========================================
+ Coverage 28.24% 28.26% +0.02%
==========================================
Files 278 278
Lines 25403 25403
Branches 3718 3718
==========================================
+ Hits 7175 7181 +6
+ Misses 17947 17941 -6
Partials 281 281
Continue to review full report at Codecov.
|
@willsputra @PixelantDesign for the feature review |
Looks like a lot of heat at #6245. I guess we can close this :). |
@vbstreetz really nice work on this - do you have any interest in building upon this work and extending dark mode across the site? Let me know CC: @owocki |
@danlipert Sure! When can I resume? 😎 |
@vbstreetz i just created this github issue for you. #6530 would love to throw a couple ETH in that. how big/complex do you think itll be? |
@vbstreetz there where some missing components styles so I decided to fix it since was a blocker for deploy and also to fit the design proposed. Please take a look on the PR #6531 |
Hey! I see @octavioamu made some big progress 😎... i'll check it out more soon. @owocki Cool! Though hard to tell an exact estimate but am def available for 2 weeks from 18th (work vacation) if its not too far? (sorry, i should have hinted this earlier). |
checkout what @octavioamu did. if we do more bounties, would love to have the PRs submitted with the same style/level of quality that it was after both you/octavio had a pass at it. |
Also see demo video
Description
Todos
Refers/Fixes
Gitcoin bounty
Testing
Work in progress...