Enable Dope (Dark) Mode on TownSquare 🌙

[molecula451]

Description

• Localstorage to keep user preference on the site
• Button toggle/untoggled if certain mode selected

Refers/Fixes

fix #6223

Testing

Local env. Still on going testing for activity stream

[codecov]

Codecov Report

Merging #6245 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6245   +/-   ##
=======================================
  Coverage   27.29%   27.29%           
=======================================
  Files         287      287           
  Lines       26712    26712           
  Branches     3945     3945           
=======================================
  Hits         7290     7290           
  Misses      19155    19155           
  Partials      267      267           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbc931...ecbc931. Read the comment docs.

[owocki]

does it stick between page loads?

@willsputra what should we do about people who have dark mode town square when they go to the rest of the site? should we dark mode the rest of the site too?

[molecula451]

@owocki Yes, localstorage when page loads so it keeps user preferences

[molecula451]

if its for the whole site can be perform just inheritance the dark classes and it will keep across site

[willsputra]

@owocki @molecula451 ideally yes, the rest of the site should be dark mode too.

i haven't really looked at how the rest of the site would look like in dark mode, though. might need some fixes afterwards if it breaks parts of the site.

[willsputra]

the town square dark mode is looking great tho! 👍@molecula451

[molecula451]

@owocki @octavioamu @willsputra watch it on reloading

[molecula451]

I would go Townsquare only. It's a whole different space than the other sections

[owocki]

sounds like people voted for town square only to start so i vote we proceed with that

…

On Thu, Mar 19, 2020 at 12:15 AM Paul ***@***.***> wrote: I would go Townsquare only. It's a whole different space than the other sections — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6245 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCO6AG5DACQ7UDDZN3LRIGZ6VANCNFSM4LNCCZLA> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $3.5mm for Open Source Software - see our results <https://gitcoin.co/results>

[molecula451]

Yes, let's do it. Townsquare first ahead! giving the last touch so it ships and ready to review

[owocki]

can the status updates themselves also go into dark mode? having the posts in light mode and the background in dark mode is kinda harsh on the eyes

[molecula451]

Yes @owocki the 'toggle' as is. Is providing the whole functionality while maintaining user preference. Classes are just being inherit and providing an easy way to handle for further maintenance to the whole site if. and as you wish

[walidmujahid]

#6258

[molecula451]

When a poll happens:

[molecula451]

@walidmujahid Any feedback is very welcoming my friend!

[molecula451]

there is no need for further complexity the toggle is providing me the expected POWER, and classes are just being inhering as fun

[molecula451]

When activity appears: (1 new activity on Townsquare)

[molecula451]

DOPE MODE and Daily Actions active

[molecula451]

Perhaps if some users wants to make any contribution their better well decide to contribute onto some implementations made by "approved contributors" this will respect guidelines on the philosophy of working & Open Source Software and will for sure contribute to the whole project, platform (Gitcoin) to make a better experience for everyone & working with everyone

[molecula451]

Some UI thoughts on the implementation:

Youtube's Dark Mode:

• Does not change icon when changing modes
• The button is hide on the user menu
• So far provide a contextual info on what the option do
• Do not change text

Uniswap's Dark Mode:

• Provides a minimal custom-switch with embedded icons (not changing - it gives the sensation that something change, tho)

So far the Gitcoin's Dope Mode has it's own minimal "custom-switch" without too much fancy, very customizable for most part of the site and with it's own touch (Dope Mode) and it does what it is intented to.

[octavioamu]

Hey guys what's the point in post-posing the feature application, and not working along one PR. #6258 The user was not approved to work. User went ahead and opened a PR. What's the point? in being approved or not can you please guy make a honest one-time decision. The only one I've seen so far taken a decision was @danlipert

@thelostone-mc is a lot indifferent.

@owocki
@octavioamu

Man worry about your PR if you are accepted to work and you are working on you PR then focus on that, I already let is clear in the first discussion about this when you actually started before the bounty was created #6223 (comment) So there is not sense to create any stress about it, trust on your work if someone else want to submit PR, well is open source, another thing is the agreement about who was approved to work / receive at the end.

[danlipert]

@molecula451 looks like travis is failing - can you fix the lint errors? thanks!

[molecula451]

Thank you for such an eye-opener words great @octavioamu this pumped me today! appreciate it a lot

@danlipert I have fixed all lint errors within this implementation.

[molecula451]

Good to push gentlemen :) build passing