Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user, I want to browse the town square in dark mode 🌙 #6223

Closed
willsputra opened this issue Mar 13, 2020 · 26 comments
Closed

As a user, I want to browse the town square in dark mode 🌙 #6223

willsputra opened this issue Mar 13, 2020 · 26 comments

Comments

@willsputra
Copy link
Contributor

User Story

As a user, I want to browse the town square in dark mode 🌙

Description

Type:
Feature

Current Behavior

No night mode

Expected Behavior

User can browse the town square in dark mode
Put a toggle to switch from light to dark mode and vice versa

figma link: https://www.figma.com/file/pu7gNTLMDT6SIZABJHH0T9/Gitcoin-Town-Square-Dark-Mode?node-id=0%3A548

darkmode
@owocki
Copy link
Contributor

owocki commented Mar 13, 2020 via email

@willsputra
Copy link
Contributor Author

yea I think @molecula451 is interested to work on this!
https://gitcoin.co/townsquare?tab=activity:158979

@ATorbMain
Copy link

I'm rather new to all this, if I wanted to help with this how would I get started?

@owocki
Copy link
Contributor

owocki commented Mar 13, 2020

lets figure out who wants to work on it then bounty it (or just make a handshake deal to tip afterwards)

new contributor docs are at https://github.com/gitcoinco

@ATorbMain
Copy link

Oh thank you! I'll get to reading those ^v^

@x5engine
Copy link
Contributor

I want to bounty on it :) Just hit me up with anything you need guys!

@ATorbMain
Copy link

I'd love to work on this!

@x5engine
Copy link
Contributor

@ATorbMain let's work on this :)

@ATorbMain
Copy link

It'd be a pleasure to!

@x5engine
Copy link
Contributor

my pleasure too :)

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.5 ETH (56.34 USD @ $112.68/ETH) attached to it.

@octavioamu
Copy link
Contributor

octavioamu commented Mar 16, 2020 •
edited
Loading

To the person who will do this one.
Be aware you need to use css inheritance so one class at the top of the document should change all the components colors.

@gitcoinbot
Copy link
Member

gitcoinbot commented Mar 16, 2020 •
edited
Loading

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 year, 10 months ago.
Please review their action plans below:

1) brad-decker has applied to start work (Funders only: approve worker | reject worker).

Greetings! I would love for this to be my first bounty on Gitcoin. This seems like a fun task. My first plan of action would be to review the existing styling system for gitcoin and find a way to add a modifier class to the body of the page when a user has selected darkmode. Then i'll use the style system to modify the existing component styles when the top-level modifier is present.
2) vbstreetz has applied to start work (Funders only: approve worker | reject worker).

Implement the dark mode theme (with provision for support for other themes). Use "prefers-color-scheme" media query to detect OSX dark mode. Also, allow user to opt-out of automatic OSX light/night mode.
3) molecula451 has been approved to start work.

Straightforward Working on it already!
4) sebastiantf has applied to start work (Funders only: approve worker | reject worker).

  1. Create a new dark theme for Townsquare in CSS
  2. Implement a simple, easy-to-use toggle button/feature to switch between the dark/light themes on Townsquare
    5) thecydonian has applied to start work (Funders only: approve worker | reject worker).

I am currently working on the status updates background update, and if I worked on this at the same time, I could ensure the styling was compatible. Idk if this is the best option, but I just wanted to throw out the idea.

Learn more on the Gitcoin Issue Details page.

@molecula451
Copy link
Contributor

molecula451 commented Mar 17, 2020 •
edited
Loading

@owocki I got half of the work done just need to finish all style as ocativou said

record-01283617032020

@molecula451 molecula451 mentioned this issue Mar 17, 2020
Closed
2 tasks
@brad-decker
Copy link

@owocki are we supposed to start working on this before being approved through Gitcoin? Trying to figure this system out. I haven't yet started work.

@owocki
Copy link
Contributor

owocki commented Mar 17, 2020

@brad-decker @molecula451 no we are not supposed to :P

@owocki
Copy link
Contributor

owocki commented Mar 17, 2020

will look thru peoples profiles today

@octavioamu
Copy link
Contributor

@brad-decker sometimes what happens is people already started to work when an issue wasn't a bounty. For example this issue born in a town square post time ago from a member who asked to get darkmode.
@molecula451 asked to work 12 days ago here https://gitcoin.co/townsquare?tab=activity:158979 and seems he already started before the bounty.
But yes "traditional" bounties is one person work in the bounty. Others bounty types like cooperative or contest more than one person work at the same time. (like hackathons)

@brad-decker
Copy link

Thanks for the info @owocki and @octavioamu -- If that's the case I think @molecula451 should have dibs on the bounty. Is there a way to create a bounty on gitcoin that is private/pre-allocated to a person?

@owocki
Copy link
Contributor

owocki commented Mar 18, 2020

im going to approve molecula. sorry for the confusion here everyone.

Is there a way to create a bounty on gitcoin that is private/pre-allocated to a person?

yes and in hindsight i should have used it!

@owocki
Copy link
Contributor

owocki commented Mar 18, 2020

@molecula451 any interest in extending your dark mode PR to the rest of the site? i could see that being a great 'collaborative' bounty for everyone on this thread to jam on together.

@molecula451
Copy link
Contributor

@owocki It's time for poll. What do you think. Let's ask the community on townsquare? Dark mode only townsquare or whole site?

@owocki
Copy link
Contributor

owocki commented Mar 19, 2020 via email

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.5 ETH (58.55 USD @ $117.09/ETH) has been submitted by:

  1. @molecula451

@owocki please take a look at the submitted work:

@kelonye kelonye mentioned this issue Mar 20, 2020
Merged
2 tasks
@gitcoinbot
Copy link
Member

Qa Ninja ⚡️ A *Qa Ninja* Kudos has been sent to @molecula451 for this issue from @owocki. ⚡️

Nice work @molecula451!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.5 ETH (103.98 USD @ $207.96/ETH) attached to this issue has been approved & issued to @molecula451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Dope (Dark) Mode on TownSquare 🌙
9 participants
@owocki @octavioamu @brad-decker @thelostone-mc @x5engine @willsputra @gitcoinbot @molecula451 @ATorbMain