-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status upload file feature #5840
Conversation
be1e886
to
7c8c382
Compare
@octavioamu @owocki @danlipert, how do you want this to look like? if that image is flagged by >3 people or an admin, then it is hidden + the user is not able to upload images anymore AFAIK, the flagging haapens on each of the updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove migrations and recreate as one neat migration + left a few other comments
Could you add a recording of the PR
Codecov Report
@@ Coverage Diff @@
## master #5840 +/- ##
==========================================
- Coverage 29.55% 29.54% -0.01%
==========================================
Files 266 266
Lines 22653 22661 +8
Branches 3289 3291 +2
==========================================
+ Hits 6694 6696 +2
- Misses 15682 15688 +6
Partials 277 277
Continue to review full report at Codecov.
|
Removing the migrations and creating again yields same result |
The issue is that a merge had to be done which makes for a non linear path on migrations. If you remove the migrations, rebase onto master and recreate the migrations you should get a single file created. If not ping me on chat and we can figure it out, I have had to go through this a number of times already. |
@iamonuwa do the images get shown anywhere in the feed or will that be a separate PR? I'd like to see that functionality together |
Separate PR, yes. The spec of this PR was to allow status upload |
what does the image look like when its been posted to the feed? does it look good on mobile/desktop/tablet? |
@owocki, it uploads to s3 |
@owocki, this pr uploads images with the status but doesn't display I. |
ah ok when i said this i meant that it should be displayed :) |
Am going to show image if status has an image attached. |
how goes? we get this feature requested regularly.. can we get it mergeable? |
waiting for reviews |
@iamonuwa does this PR now show the uploaded image or is that coming in a followup PR? |
Follow up PR. This weekend. Everywhere is hot right now with the pandemic. |
no worries man - stay safe |
@iamonuwa looks like this PR has gotten stale! Could you throw in a fresh PR whenever you get around to this & we can get this in ? |
Description
Allow users to upload images as part of status
Refers/Fixes
Fixes #5832
Testing
Check the user profile, try uploading an image alongside the status or check the townsquare status box