Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade townsquare UI #5968

Merged
merged 46 commits into from
Feb 10, 2020
Merged

feat: upgrade townsquare UI #5968

merged 46 commits into from
Feb 10, 2020

Conversation

thelostone-mc
Copy link
Member

Description

This picks from the changes made by @mul1sh over at #5877
It's got a few additional changes => to ensure the UI remains consistent across the site a few minor bugs

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (stable@3faef78). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             stable    #5968   +/-   ##
=========================================
  Coverage          ?   28.84%           
=========================================
  Files             ?      271           
  Lines             ?    23682           
  Branches          ?     3442           
=========================================
  Hits              ?     6830           
  Misses            ?    16579           
  Partials          ?      273
Impacted Files Coverage Δ
app/marketing/views.py 10.98% <0%> (ø)
app/kudos/views.py 14.83% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faef78...1e8a841. Read the comment docs.

@octavioamu octavioamu changed the base branch from master to stable February 10, 2020 15:10
@owocki
Copy link
Contributor

owocki commented Feb 10, 2020

local testing QA notes:

  1. ✔️ I cant seem to click on any of the actions even when its adverttised that they are available.. https://bits.owocki.com/RBudeqOe -- if it was working, id ask that we create some sort of animation on the actions to draw the users eye there? similar to existing town square...
  2. ✔️ the 'email when available' checkbox is no longer wired up.
  3. ✔️ can we make the eth logo black not blue? https://bits.owocki.com/geu2jwzG
  4. ✔️ we should hide these tabs if they dont do anything https://bits.owocki.com/X6uzqo0Y
  5. ✔️ lets hide this if were not using it yet https://bits.owocki.com/DOu8RA2A
  6. ✔️ text wrap CSS fix pls ! https://bits.owocki.com/xQugPDb2
  7. ✔️ on the profile(not the newsfeed) we should make the heart and comment buttons black instead of blue for consistentcy https://bits.owocki.com/4gumwjPJ
  8. ✔️ i see we moved the comment input from an alert to an in page module.. can we make it so u press enter on this comment text box and it submits?
  9. ✔️ looks like on font awesome icons onthe new_grants_contribution activity feed items are broken https://bits.owocki.com/OAur0B2N ;

finally would it be possible to get #5840 and #5898 in too ? or should that be a v2? i was hoping to start do a daily founder update video and posting it to the townsquare to create something for ppl to come back to..

@owocki owocki merged commit 1e8a841 into stable Feb 10, 2020
@thelostone-mc thelostone-mc deleted the improv/townsquare-ui branch June 27, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants