Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5881

Closed
owocki opened this issue Jan 24, 2020 · 14 comments

Comments

@owocki
Copy link
Contributor

owocki commented Jan 24, 2020

User Story

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money

Why Is this Needed

Summary:
people like money airdrops

Description

Type:
feature

Current Behavior

no token attach

Expected Behavior

  • a 'attach tokens' button on the status update bottom
  • when its clicked, a user is prompted to select a token (any token listed at /settings/tokens can be added) and enter an amount
  • user can submit the status update and when they do this function ( https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/pages/bulk_payout.js#L140-L155 ) is called and they are prompted to send tokens. once they send tokens, the status update is posted
  • on the status update, there is a nice visual box that shows there are tokens attached to the post.
  • after users comment on the post, the poster (and only the poster) can click an "award" button next to each comment to award any commenter the tokens.

Definition of Done

  • please hookup the frontend as much as you can. i can run with the backend and redemption of the funds after the frontend is hooked up and working.

Additional Information

pls only apply if u can PR within 48 hours.

See also: #5840

@owocki
Copy link
Contributor Author

owocki commented Jan 24, 2020

#5882
#5881
#5880

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0 ETH (164.24 USD @ $164.24/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Jan 24, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 6 days from now.
Please review their action plans below:

1) katya559 has applied to start work (Funders only: approve worker | reject worker).

Provide an action plan and any initial questions you have for this ticket.
(Your response will be reflected in a comment on the Github issue.)
2) zoek1 has been approved to start work.

i'll add the button and add a modal requesting the token and the amount. After that, I'll add the fox icon (i'm not sure if the amount as well) to the post.
I'll add a button and validate that only the reward button is displayed to de poster user

Learn more on the Gitcoin Issue Details page.

@zoek1
Copy link
Contributor

zoek1 commented Jan 25, 2020

I sent a PR, just to finish the flow I have a question: why the funds are sent at step 2 and not in award step 4? I'm not sure if the amount will be sent to only one user or will be split into many accounts. Also after the difference between the amount awarded and defined previously is 0, will be the button "award" disappear? @owocki

@KiChjang
Copy link
Contributor

KiChjang commented Jan 25, 2020

@zoek1 You're supposed to be first approved by the funder before you can work on issues. The Gitcoin issues details page tells you that if you hover over Project Type and Permissions. It should also have told you this in a modal with a checkbox when you clicked Express Interest in the issue details page.

@owocki
Copy link
Contributor Author

owocki commented Jan 28, 2020

yeah i agree we should have better hygene abou tthat.. @zoek1 ill approve u on this bounty. @KiChjang and @katya559 pick another github issue on the issue board and dig in; ill tip you for that one instead :)

@zoek1
Copy link
Contributor

zoek1 commented Jan 28, 2020

I was motivated the past weekend so I started to develop on this. I'm so sorry @KiChjang, I didn't know that is reserved for someone 🙏
@owocki can you help with this:

why the funds are sent at step 2 and not in award step 4? I'm not sure if the amount will be sent to only one user or will be split into many accounts. Also after the difference between the amount awarded and defined previously is 0, will be the button "award" disappear?

@owocki
Copy link
Contributor Author

owocki commented Jan 29, 2020

@zoek1 you should be able to extract the usage of the tips functionality behind the sendTip() function and not have to worry about it

for receiving the tip.. you just need to display the tip.receive_url to the user

Also after the difference between the amount awarded and defined previously is 0, will be the button "award" disappear?

once the tip has a receive_tx i think we should not display the award button anymore

@zoek1
Copy link
Contributor

zoek1 commented Jan 30, 2020

👌 thanks! I'll do that!

@gitcoinbot
Copy link
Member

gitcoinbot commented Feb 1, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 3 days from now.
Please review their action plans below:

1) katya559 has applied to start work (Funders only: approve worker | reject worker).

Provide an action plan and any initial questions you have for this ticket.
(Your response will be reflected in a comment on the Github issue.)
2) zoek1 has been approved to start work.

i'll add the button and add a modal requesting the token and the amount. After that, I'll add the fox icon (i'm not sure if the amount as well) to the post.
I'll add a button and validate that only the reward button is displayed to de poster user

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.0 ETH (179.96 USD @ $179.96/ETH) has been submitted by:

  1. @zoek1

@owocki please take a look at the submitted work:


@owocki
Copy link
Contributor Author

owocki commented May 31, 2020

will pay this out when its deployed + working ok in prod. setting a reminder for next week!

@gitcoinbot
Copy link
Member

Discovery ⚡️ A *Discovery* Kudos has been sent to @zoek1 for this issue from @owocki. ⚡️

The sender had the following public comments:

zoek is da bomb

Nice work @zoek1!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1.0 ETH (243.67 USD @ $243.67/ETH) attached to this issue has been approved & issued to @zoek1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants