as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5884

zoek1 · 2020-01-25T12:27:02Z

Description

a 'attach tokens' button on the status update bottom
when its clicked, a user is prompted to select a token (any token listed at /settings/tokens can be added) and enter an amount
user can submit the status update and when they do this function ( https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/pages/bulk_payout.js#L140-L155 ) is called and they are prompted to send tokens. once they send tokens, the status update is posted
on the status update, there is a nice visual box that shows there are tokens attached to the post.
after users comment on the post, the poster (and only the poster) can click an "award" button next to each comment to award any commenter the tokens.

Refers/Fixes

#5881

Testing

zoek1 · 2020-01-25T12:29:01Z

I'm based on changes of #5883, is the UI fine to specify the amount and award the tokens?

codecov · 2020-01-25T12:33:58Z

Codecov Report

Merging #5884 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5884   +/-   ##
=======================================
  Coverage   26.70%   26.70%           
=======================================
  Files         293      293           
  Lines       27675    27675           
  Branches     4086     4086           
=======================================
  Hits         7391     7391           
  Misses      20019    20019           
  Partials      265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70098d9...70098d9. Read the comment docs.

danlipert · 2020-01-27T15:56:46Z

Excited for this! Let me know once its ready for review

zoek1 · 2020-01-28T10:30:32Z

I'm asking to solve some questions in the original issue to unlock this 😃

owocki · 2020-01-31T01:21:48Z

I'm asking to solve some questions in the original issue to unlock this 😃

i wanna push on this soon.. r u still blocked? link me the questions?

zoek1 · 2020-01-31T03:01:53Z

No problem @owocki, in working on this right now! In the morning the PR will ve ready to Review :thumbs_up:

zoek1 · 2020-01-31T13:36:45Z

It's ready for review @owocki @danlipert 😃

owocki · 2020-01-31T19:48:01Z

feedback -

wow it works end to end.. yay!
https://bits.owocki.com/geurNd5Y can we make this area black, and also show the token amount + token name eg "0.01 ETH attached" isntead of' Tip attached"
when i award the tip, does the to user get an email?
when i visit the page incognito i get a 500 https://bits.owocki.com/qGuDm7PO
when i post a new comment i get this issue https://bits.owocki.com/yAuLEK8J

zoek1 · 2020-02-01T00:45:57Z

show the token amount + token name eg "0.01 ETH attached" isntead of' Tip attached"
when i award the tip, does the to user get an email?
when i visit the page incognito i get a 500 https://bits.owocki.com/qGuDm7PO
when i post a new comment i get this issue https://bits.owocki.com/yAuLEK8J

https://bits.owocki.com/geurNd5Y can we make this area black

i'm not sure what region should be black, The button, the comments or the status: 😅

@owocki

zoek1 · 2020-02-05T22:36:11Z

@owocki fix conflicts done!

zoek1 · 2020-02-07T21:47:31Z

@owocki I recently read the tip functionality is live, is this PR still relevant?

octavioamu · 2020-02-11T13:14:49Z

I will say yes, still totally valid and interesting feature.

owocki · 2020-02-11T17:40:26Z

yeah staking on posts is an important mechanism.. would love to get this working on the new townsquare + get it into an upcoming release...

zoek1 · 2020-02-14T20:47:19Z

Do you consider change something based on what you tested? I'll integrate this weekend the new square town into this.
@owocki

danlipert · 2020-02-18T13:49:13Z

Hey @zoek1 - @owocki is Out-of-office for a bit so I'll take over in the meantime, looks like this is rebased and ready for review and merge, right?

danlipert · 2020-05-13T15:33:59Z

app/dashboard/templates/profiles/status_box.html

+              <select class="form-control" id="attachToken">
+                <option value="0x0">ETH</option>
+              {% for token in TOKENS %}
+                <option value="{{ token.token_addres }}">{{ token.token_name }}</option>


Was this only tested with ETH? There is a typo here for the token_address

Thanks, I missed that. I tested with some ERC20 tokens like MANA and GNT.

zoek1 · 2020-05-27T11:11:43Z

@danlipert do you think this could be merge soon? it's tested with eth and tokens 😛

@owocki

zoek1 requested review from danlipert, octavioamu and thelostone-mc as code owners January 25, 2020 12:27

Add UI and interaction to setup tips on comments

bcd11de

zoek1 force-pushed the feature/tip-comments branch from f8b8c0a to bcd11de Compare January 25, 2020 12:33

zoek1 added 2 commits January 31, 2020 03:20

Merge style to mantain consistency

937b1d4

Add transaction process to attach and redeem from status

a7fb1f6

Fix errors on anonymous access

15a4392

gitcoinbot mentioned this pull request Feb 1, 2020

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5881

Closed

zoek1 mentioned this pull request Feb 5, 2020

as a end user I would like to be able to attach preset memes to my status update on gitcoin, so i can share memes #5898

Merged

4 tasks

owocki mentioned this pull request Feb 7, 2020

Enhancement: Apply new design to townsquare #5877

Closed

Integrate tips on comments based into new townsquare

0fc7a56

zoek1 force-pushed the feature/tip-comments branch from a24f38f to 0fc7a56 Compare February 18, 2020 06:10

zoek1 changed the base branch from master to stable February 18, 2020 06:11

integrate with latest stable changes

f7ec1de

Fix conflict with master

716bc0e

zoek1 force-pushed the feature/tip-comments branch from 6bffa80 to 716bc0e Compare May 5, 2020 17:32

Merge branch 'master' into feature/tip-comments

d192526

danlipert suggested changes May 13, 2020

View reviewed changes

danlipert marked this pull request as draft May 13, 2020 15:34

thelostone-mc and others added 4 commits May 13, 2020 21:04

Merge branch 'master' into feature/tip-comments

7bc27e6

Update status_box.html

1171f12

Merge branch 'master' into feature/tip-comments

f58c21e

Rollback missing library

7199c69

zoek1 marked this pull request as ready for review May 14, 2020 21:54

zoek1 requested a review from danlipert May 15, 2020 02:41

Merge branch 'master' into feature/tip-comments

35d4887

thelostone-mc approved these changes May 19, 2020

View reviewed changes

zoek1 added 7 commits May 20, 2020 02:43

Merge branch 'master' into feature/tip-comments

5ebff37

Merge branch 'master' into feature/tip-comments

8f3f93a

Update migration

fcea83f

Merge branch 'master' into feature/tip-comments

13af9cd

Fix migration erros

2d3ea32

Merge branch 'master' into feature/tip-comments

70e4008

Merge branch 'master' into feature/tip-comments

f65c42b

Merge branch 'master' into feature/tip-comments

70098d9

thelostone-mc merged commit 3826ae6 into gitcoinco:master May 27, 2020

zoek1 mentioned this pull request Jun 5, 2020

i just awarded the ETH associated with a status update. where did it go? #6773

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5884

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5884

zoek1 commented Jan 25, 2020 •

edited

Loading

zoek1 commented Jan 25, 2020

codecov bot commented Jan 25, 2020 •

edited

Loading

danlipert commented Jan 27, 2020

zoek1 commented Jan 28, 2020

owocki commented Jan 31, 2020

zoek1 commented Jan 31, 2020

zoek1 commented Jan 31, 2020

owocki commented Jan 31, 2020

zoek1 commented Feb 1, 2020

zoek1 commented Feb 5, 2020

zoek1 commented Feb 7, 2020

octavioamu commented Feb 11, 2020

owocki commented Feb 11, 2020

zoek1 commented Feb 14, 2020

danlipert commented Feb 18, 2020

danlipert May 13, 2020

zoek1 May 14, 2020

zoek1 commented May 27, 2020

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5884

as a end user I would like to be able to attach ETH/tokens to my status update on gitcoin, so i can share money #5884

Conversation

zoek1 commented Jan 25, 2020 • edited Loading

Description

Refers/Fixes

Testing

zoek1 commented Jan 25, 2020

codecov bot commented Jan 25, 2020 • edited Loading

Codecov Report

danlipert commented Jan 27, 2020

zoek1 commented Jan 28, 2020

owocki commented Jan 31, 2020

zoek1 commented Jan 31, 2020

zoek1 commented Jan 31, 2020

owocki commented Jan 31, 2020

zoek1 commented Feb 1, 2020

zoek1 commented Feb 5, 2020

zoek1 commented Feb 7, 2020

octavioamu commented Feb 11, 2020

owocki commented Feb 11, 2020

zoek1 commented Feb 14, 2020

danlipert commented Feb 18, 2020

danlipert May 13, 2020

Choose a reason for hiding this comment

zoek1 May 14, 2020

Choose a reason for hiding this comment

zoek1 commented May 27, 2020

zoek1 commented Jan 25, 2020 •

edited

Loading

codecov bot commented Jan 25, 2020 •

edited

Loading