Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details : remove full name #2759

Merged
merged 2 commits into from
Nov 12, 2018
Merged

details : remove full name #2759

merged 2 commits into from
Nov 12, 2018

Conversation

thelostone-mc
Copy link
Member

  • removed funder name from details page
  • ensures email label + field is shown only if available
  • cleans up extra code

Fixes: #2579

screen shot 2018-11-11 at 12 43 38 am

- ensures email label + field is shown only if available

Fixes: gitcoinco#2579
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2759 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   28.89%   28.85%   -0.05%     
==========================================
  Files         163      163              
  Lines       13080    13080              
  Branches     1753     1753              
==========================================
- Hits         3780     3774       -6     
- Misses       9193     9199       +6     
  Partials      107      107
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56405d6...5234115. Read the comment docs.

@SaptakS SaptakS merged commit c6d53b5 into gitcoinco:master Nov 12, 2018
@thelostone-mc thelostone-mc deleted the username branch November 12, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants