Remove full name entry + hide in form.

[Anish-Agnihotri]

Description

This is a simple commit that simply defaults the details.html page to take username as default value rather than full name, and removes the option to add a full name altogether from new.html. It's a simple commit which does this through:

1. Removing the option to add a name.
2. Defaulting occurrences of bounty_owner_name to result.bounty_owner_github_username in bounty_details.js. Since the option to anonymize full name has been removed altogether, I've also taken out the code that was committed previously for hide funder details when funder selects to be Anonymous #2273.

Checklist

• linter status: 100% pass
• changes don't break existing behavior
• commit message follows commit guidelines

Affected core subsystem(s)

User Interface.

Testing

Tested cross-platform as usual and a few times with various issues on Rinkeby to ensure function.

Refers/Fixes

Fixes #2748, removes need for #2273.

CC: @frankchen07

[thelostone-mc]

Could we do away with the shared/name.html ( any styling associated with it )

Also the funder we should the email if the funder chooses to keep that data hidden.
I've covered those as a part of #2759 ?

could you undo the changes at bounty_details.jselse we'll end up with conflicts ? 😅

[codecov]

Codecov Report

Merging #2757 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2757   +/-   ##
=======================================
  Coverage   28.89%   28.89%           
=======================================
  Files         163      163           
  Lines       13080    13080           
  Branches     1753     1753           
=======================================
  Hits         3780     3780           
  Misses       9193     9193           
  Partials      107      107

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39af78e...6a39622. Read the comment docs.

[Anish-Agnihotri]

Ah yes. Your pr at #2759 is certainly more robust than this in every way, haha.

There are no styles associated with name.html file as far as I know so that shouldn't be a problem. Although, fullName as a var is mentioned in a few files, let me know if you want me to remove that.

Other than that, I'd be glad to simply delete this PR altogether, and you can just add the one-liner to remove shared/name.html from the new issue page yourself, so that the code is consistent.

[thelostone-mc]

@Anish-Agnihotri added it into this PR ^_^