Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing post-synchronisation for issue founders #2579

Closed
kuhnchris opened this issue Oct 30, 2018 · 9 comments
Closed

Missing post-synchronisation for issue founders #2579

kuhnchris opened this issue Oct 30, 2018 · 9 comments
Assignees
Labels
bug This is something that isn't working as intended. Gitcoin Issue Detail Gitcoin Issue Detail

Comments

@kuhnchris
Copy link
Contributor

Describe the bug
Apparently some funders of issues aren't properly connected to their profiles.

To Reproduce
Not sure, can't reproduce on purpose

Expected behavior
Have the issue funder's name displayed

Screenshots
image

Desktop (please complete the following information):

  • OS: Mac OS X
  • Browser Chrome
  • Browser Version Latest Stable
@kuhnchris
Copy link
Contributor Author

For reference: The affected bounty is this one:
https://gitcoin.co/issue/gitcoinco/web/2508/1650

@PixelantDesign PixelantDesign added the bug This is something that isn't working as intended. label Oct 30, 2018
@PixelantDesign
Copy link
Contributor

Thanks for the report @kuhnchris!

@frankchen07
Copy link
Contributor

Ah, beat me to it. 😄 good catch!

@thelostone-mc
Copy link
Member

So what probably happened is that the options below were checked by default causing the name to be rendered Anonymous

screen shot 2018-11-09 at 12 11 16 am

For Activities we track user action which doesn't taken into account if the funder has selected hide options.

We could either

  • remove those options
    (personally I don't think we would need it cause it openness == transparency )
  • update the Activity to keep track of that ( which might be a bit more tricker )

Here is the API response for that bounty :
https://gitcoin.co/actions/api/v0.1/bounties/?github_url=https://github.com/gitcoinco/web/issues/2508

@PixelantDesign @frankchen07

@kuhnchris
Copy link
Contributor Author

image
That seems redundant at best. if any of those values is not "Anonymous" then it wouldn't make sense to hide 'any' of em...

@thelostone-mc
Copy link
Member

So we always display the github username in the activities stream but on the footer we display the name of the funder which in this case @PixelantDesign has chosed to hide which is why that is anonymous.

The most sensible thing at this point in my head is

  • Show the github username as opposed to the name of the funder in the funder info.
  • Or do a check to see if funder doesn't want his name to be shown -> instead show github username

@frankchen07
Copy link
Contributor

I like your thought that the default should be showing the Github username - let's implement that.

As for checking to see if the funder wants his/her full name shown, I want to open another ticket and place it to the greater team on removing the anonymity function on the funder form completely, since it's not truly anonymous. It's also adds another concerning decision point for the funder to make about their data.

Anonymous only works if it's completely carried throughout the "All Activity" section and throughout Github (which isn't possible). To me, it doesn't make sense to be in open source, funding issues, and remain anonymous - that's sort of the reputation part of open source.

thelostone-mc added a commit to thelostone-mc/web that referenced this issue Nov 10, 2018
- ensures email label + field is shown only if available

Fixes: gitcoinco#2579
@thelostone-mc
Copy link
Member

@kuhnchris 7 @frankchen07 we've got a fix out over at #2759 ^_^

@kuhnchris
Copy link
Contributor Author

Great, thanks for the hard work! :-)

thelostone-mc added a commit to thelostone-mc/web that referenced this issue Nov 12, 2018
- ensures email label + field is shown only if available

Fixes: gitcoinco#2579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended. Gitcoin Issue Detail Gitcoin Issue Detail
Projects
None yet
Development

No branches or pull requests

4 participants