backend db & API support to show how many comments exist for an issue #219

amites · 2018-01-06T01:08:50Z

Description

add support to bounties API for github comment count
add function to Bounty model to pull github comments
extend refresh_bounties command to pull github comments & update

Checklist

linter status: 100% pass
- Didn't touch anything in nodejs land, new code would pass pylint -- existing gonna take some effort to clean -- separate PR
changes don't break existing behavior
commit message follows [commit guidelines]

Affected core subsystem(s)

dashboard
bounty API

Refers/Fixes

Works on: #206

- add function to Bounty model to pull github comments - extend refresh_bounties command to pull github comments & update Refs: gitcoinco#206

amites · 2018-01-06T01:10:50Z

app/app/github.py

@@ -45,12 +45,15 @@ def search(q):
    return response.json()


-def get_issue_comments(owner, repo):
+def get_issue_comments(owner, repo, issue=None):


couldn't find any existing usages of this function

method signature remains consistent but allows for retrieving comments of a single issue

👍 Some of the functionality has changed in the GH integration PR.

amites · 2018-01-06T01:11:12Z

app/app/settings.py

@@ -200,6 +200,10 @@
 SECURE_HSTS_PRELOAD = True
 SECURE_HSTS_SECONDS = 3600

+# List of github usernames to not count as comments on an issue
+IGNORE_COMMENTS_FROM = ['gitcoinbot', ]


put this here to make it easy to override

this is very nice.. thanks

amites · 2018-01-06T01:11:47Z

app/dashboard/migrations/0031_auto_20180105_1659.py

+            name='github_comments',
+            field=models.IntegerField(default=0),
+        ),
+        migrations.AlterField(


added help_text to 2 of the fields -- keeping them here to avoid generating extra migrations

amites · 2018-01-06T01:12:32Z

app/dashboard/models.py

@@ -252,6 +254,30 @@ def fetch_issue_description(self):
        if body:
            self.issue_description = body

+    def fetch_issue_comments(self, save=True):


uses the app.github method to pull comments via API vs parsing html

This has changed in: #156

not sure which PR will land first, easy enough to pull your changes in but I'll wait till this has had a 2nd review

digging what I see in #156

amites · 2018-01-06T01:38:56Z

Travis CI failures are unrelated to this PR -- have a question about process to fix in Slack

https://gitcoincommunity.slack.com/archives/C7BQHUPAN/p1515202126000159

mbeacom · 2018-01-07T20:15:34Z

app/dashboard/models.py

@@ -252,6 +254,30 @@ def fetch_issue_description(self):
        if body:
            self.issue_description = body

+    def fetch_issue_comments(self, save=True):


This has changed in: #156

mbeacom · 2018-01-07T20:16:16Z

app/dashboard/models.py

+            github_user, github_repo, _, github_issue = parsed_url.path.split('/')[1:5]
+        except ValueError:
+            # TODO: update print statements to logger
+            print('Invalid github url')


i wonder if it's worth logging and error here

probably, the repo isn't setup for using the built-in logger that I saw -- easy enough to add but was aiming for a clean PR to make it easy to review

there is some of the built in logging system being done in notifications.py ... not sure if that qualifies or helps or not

want me to throw a logging config into settings?

pretty much copy and paste, can dial it in later but will open up using logging.getLogger

mbeacom · 2018-01-07T20:16:49Z

app/app/github.py

@@ -45,12 +45,15 @@ def search(q):
    return response.json()


-def get_issue_comments(owner, repo):
+def get_issue_comments(owner, repo, issue=None):


👍 Some of the functionality has changed in the GH integration PR.

owocki · 2018-01-08T21:45:15Z

this looks good ...

as @mbeacom notes.. well have to figure out how to merge it with his work on the 'express interest' pr. donno if thatll get merged first or this will.

cc @ethikz who has been doing some of the frontend stuff

owocki · 2018-01-12T01:36:24Z

hey @amites can you please merge the frontend code into this branch? looking fwd to getting it live

amites · 2018-01-12T02:44:33Z

I'll start building it out, @ethikz had a couple snippets but far from a complete solution

wasn't sure what was in mind for process

amites · 2018-01-15T07:03:17Z

updated UI -- #156 is still open to hesitant to pull in changes

owocki · 2018-01-15T19:53:59Z

thanks. screenshots look good! i will review once the mobile UI stuff has been committed

amites · 2018-01-15T20:54:51Z

ended up fixing the mobile UI last night -- merge conflicts

owocki · 2018-01-15T21:32:18Z

app/assets/v2/css/base.css

@@ -650,8 +650,12 @@ input[type=text].loading {
    width: 45%;
    display: inline-block;
 }
+<<<<<<< HEAD


@amites merge conflict :)

owocki · 2018-01-15T21:32:33Z

app/assets/v2/css/base.css

+    background: url(/static/v2/images/icon-msg-red-16.png) no-repeat left transparent;
+}
+body.bounty_details a.btn-darkGrey{
+=======


a few more down here too

owocki · 2018-01-15T21:37:31Z

pulled down the code and ran ./manage.py refresh_bounties --remote but didnt see the UI updated at all... maybe because of the merge conflicts? what else do i need to do to test?

owocki · 2018-01-15T21:59:45Z

just tested this again after chatting with @amites on slack and it LGTM... @mbeacom 👍 from you?

mbeacom · 2018-01-15T23:03:14Z

app/dashboard/models.py

    expires_date = models.DateTimeField()
    raw_data = JSONField()
    metadata = JSONField(default={})
    claimee_metadata = JSONField(default={})
-    current_bounty = models.BooleanField(default=False) # whether this bounty is the most current revision one or not
+    current_bounty = models.BooleanField(default=False,
+                                         help_text='whether this bounty is the most current revision one or not')


Just a minor nitpick... Should we move forward with a standard of capitalizing the first letter in help_text or keep it all lowercase?

mbeacom

Other than the comment pertaining to the superfluous help_text question, LGTM!

amites · 2018-01-15T23:09:39Z

nice nit-pick for consistency -- updated

backend db & API support to show how many comments exist for an issue

postcard download and fixes

- add support to bounties API for github comment count

8768eaf

- add function to Bounty model to pull github comments - extend refresh_bounties command to pull github comments & update Refs: gitcoinco#206

amites commented Jan 6, 2018

View reviewed changes

amites changed the title ~~Provides the backend db & API support for showing how many comments exist for a given issue~~ backend db & API support to show how many comments exist for an issue Jan 6, 2018

mbeacom reviewed Jan 7, 2018

View reviewed changes

owocki mentioned this pull request Jan 8, 2018

code: signal to tell user that unclaimed issues may already be in progress #206

Closed

amites added 4 commits January 14, 2018 23:52

added comment display to dashboard and bounty details

e46911f

added logging from print

1831548

fixed style

c34cfa8

merge with master upstream

f494452

fix css merge

72e77c0

owocki reviewed Jan 15, 2018

View reviewed changes

hooked pulling github comments into refresh_bounties command

790400a

mbeacom reviewed Jan 15, 2018

View reviewed changes

mbeacom approved these changes Jan 15, 2018

View reviewed changes

sp

23a3e99

owocki merged commit 1fed033 into gitcoinco:master Jan 15, 2018

ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018

Merge pull request gitcoinco#219 from amites/206--unclaimed-progress

4d3bb20

backend db & API support to show how many comments exist for an issue

thelostone-mc added a commit that referenced this pull request May 24, 2021

Merge pull request #219 from nopslip/postcard-fixes

1010f01

postcard download and fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

backend db & API support to show how many comments exist for an issue #219

backend db & API support to show how many comments exist for an issue #219

amites commented Jan 6, 2018 •

edited

Loading

amites Jan 6, 2018

mbeacom Jan 7, 2018

amites Jan 6, 2018

owocki Jan 8, 2018

amites Jan 6, 2018

amites Jan 6, 2018

mbeacom Jan 7, 2018

amites Jan 8, 2018

amites commented Jan 6, 2018

mbeacom Jan 7, 2018

mbeacom Jan 7, 2018

owocki Jan 8, 2018

amites Jan 8, 2018

owocki Jan 8, 2018

amites Jan 8, 2018

mbeacom Jan 7, 2018

owocki commented Jan 8, 2018

owocki commented Jan 12, 2018

amites commented Jan 12, 2018

amites commented Jan 15, 2018 •

edited

Loading

owocki commented Jan 15, 2018

amites commented Jan 15, 2018

owocki Jan 15, 2018

owocki Jan 15, 2018

owocki commented Jan 15, 2018

owocki commented Jan 15, 2018

mbeacom Jan 15, 2018

mbeacom left a comment

amites commented Jan 15, 2018

backend db & API support to show how many comments exist for an issue #219

backend db & API support to show how many comments exist for an issue #219

Conversation

amites commented Jan 6, 2018 • edited Loading

Description

Checklist

Affected core subsystem(s)

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amites commented Jan 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jan 8, 2018

owocki commented Jan 12, 2018

amites commented Jan 12, 2018

amites commented Jan 15, 2018 • edited Loading

owocki commented Jan 15, 2018

amites commented Jan 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jan 15, 2018

owocki commented Jan 15, 2018

Choose a reason for hiding this comment

mbeacom left a comment

Choose a reason for hiding this comment

amites commented Jan 15, 2018

amites commented Jan 6, 2018 •

edited

Loading

amites commented Jan 15, 2018 •

edited

Loading