Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: signal to tell user that unclaimed issues may already be in progress #206

Closed
owocki opened this issue Jan 2, 2018 · 20 comments
Closed

Comments

@owocki
Copy link
Contributor

owocki commented Jan 2, 2018

#190 (comment)

requirements

  • code up the frontend from this PR
  • update the Bounty model to have the new 'no_comments' field in it
  • update Bounty.fetch_issue_description() to be entitled Bounty.fetch_github_latest, and to update the new 'no_comments' field in it (in addition to the issue desc)

to submit this issue, pls post a screenshot of the new UI... in both tablet, desktop, and mobile view

@gitcoinbot
Copy link
Member

This issue now has a funding of 0.05 ETH (42.76 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $12233.5 more Funded OSS Work Available at: https://gitcoin.co/explorer

@ethikz
Copy link
Contributor

ethikz commented Jan 3, 2018

@owocki I partially have this done, albeit statically right now I'll have to tie in the actual comments and dynamically code it. I used the current chat bubble messages that we have in icons folder but can use something different. Also, this is a rough implementation. I haven't done any measuring of spacing.

Mobile
Tablet
Desktop

I'm researching into everything that needs to be added and where everything is for the specific page and which models, etc are being used.

@owocki
Copy link
Contributor Author

owocki commented Jan 3, 2018

looks like good progress.. want to claim the issue on gitcoin so no one else does?

@thelostone-mc
Copy link
Member

@ethikz Claim it!!
Else I might just claim it to prove @owocki s point just for the heck of it 😆

PS: I'll help with the reviewing

@amites
Copy link
Contributor

amites commented Jan 3, 2018

👍 was gonna tackle this one but happy to see the community is strong enough that there's competition to get tasks completed

@ethikz
Copy link
Contributor

ethikz commented Jan 4, 2018

Someone can claim it; it's okay. I might not be able to work on the whole thing right this minute but figured I could contribute and help someone out if the person can take it across the finish line.

@owocki
Copy link
Contributor Author

owocki commented Jan 4, 2018

cc @amites @thelostone-mc

@gitcoinbot
Copy link
Member

The funding of 0.05 ETH (47.5 USD) attached has been claimed by @amites.

@amites, please leave a comment to let the funder (@owocki) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.

@ethikz
Copy link
Contributor

ethikz commented Jan 5, 2018

@amites If you want what I already have let me know and I can push it up for you

@amites
Copy link
Contributor

amites commented Jan 5, 2018

@ethikz I'd appreciate it -- taking this one a bit ambitiously and tackling the API updates along with the front-end (seemed simpler than building a mock API to have functional front-end code)

amites added a commit to amites/web that referenced this issue Jan 6, 2018
- add function to Bounty model to pull github comments
- extend refresh_bounties command to pull github comments & update

Refs: gitcoinco#206
@owocki
Copy link
Contributor Author

owocki commented Jan 8, 2018

@amites backend on #219 looks good! @ethikz you want to merge in your work too!?

looking forward to getting this out

@ethikz
Copy link
Contributor

ethikz commented Jan 9, 2018

@owocki yes the javascript should be good to merge in. if you're referring to this, @amites has the code already, we exchanged on slack

@owocki
Copy link
Contributor Author

owocki commented Jan 9, 2018

sorry im disorganized... is there a PR for that? i dont see it on #219

@ethikz
Copy link
Contributor

ethikz commented Jan 9, 2018

@owocki sorry I was referencing another PR

@owocki owocki added the feature label Jan 12, 2018
@gitcoinbot
Copy link
Member

The funding of 0.05 ETH (64.71 USD) attached to this issue has been approved & issued to @amites.

@vs77bb
Copy link
Contributor

vs77bb commented Jan 17, 2018

@owocki this is still showing up as 'Claimed' on Gitcoin... should be fulfilled?

@owocki
Copy link
Contributor Author

owocki commented Jan 17, 2018

looks fulfilled to me... am i looking at the right issue? https://gitcoin.co/funding/details?url=https://github.com/gitcoinco/web/issues/206

@vs77bb
Copy link
Contributor

vs77bb commented Jan 17, 2018

screen shot 2018-01-17 at 12 54 06 pm

@vs77bb
Copy link
Contributor

vs77bb commented Jan 17, 2018

Hmm funny, looks like it just moved to 'Fulfilled'. Seeing it there now as of this minute (two minutes ago was that screenshot 🙂

ethikz pushed a commit to ethikz/web that referenced this issue Jan 24, 2018
- add function to Bounty model to pull github comments
- extend refresh_bounties command to pull github comments & update

Refs: gitcoinco#206
@owocki
Copy link
Contributor Author

owocki commented Jan 24, 2018

@owocki owocki closed this as completed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants