GH integration and express interest #156

mbeacom · 2017-12-21T00:48:30Z

Description

The goal of this PR is to provide rough github integration to validate Profile handles and email addresses to ensure we have a valid email address to send tips/notifications. Additionally, this PR implements Express Interest functionality that will add users to a list of users that have expressed interest (displayed on the bounty page) and comments on the github issue with a list of user handles and links back to their gitcoin profile pages.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

Tips and Bounties

Refers/Fixes

Ref: #62
Ref: #98

codecov · 2017-12-21T00:55:47Z

Codecov Report

Merging #156 into master will increase coverage by 1.53%.
The diff coverage is 18.91%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   12.21%   13.74%   +1.53%     
==========================================
  Files          66       67       +1     
  Lines        3120     3282     +162     
  Branches      343      366      +23     
==========================================
+ Hits          381      451      +70     
- Misses       2739     2831      +92

Impacted Files	Coverage Δ
app/app/urls.py	`0% <ø> (ø)`	⬆️
app/dashboard/apps.py	`0% <0%> (ø)`	⬆️
app/dashboard/helpers.py	`0% <0%> (ø)`	⬆️
app/dashboard/views.py	`0% <0%> (ø)`	⬆️
...pp/economy/management/commands/refresh_bounties.py	`0% <0%> (ø)`	⬆️
app/economy/models.py	`76.66% <100%> (ø)`	⬆️
app/dashboard/notifications.py	`7.72% <11.11%> (+7.72%)`	⬆️
app/app/github.py	`26.82% <20.31%> (+26.82%)`	⬆️
app/dashboard/models.py	`42.59% <41.66%> (+4.48%)`	⬆️
app/dashboard/signals.py	`58.33% <58.33%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417b692...040e018. Read the comment docs.

owocki · 2017-12-22T19:44:06Z

good progress! submitting my comments now

owocki · 2017-12-22T19:24:01Z

app/app/local_settings.py.dist

@@ -92,6 +92,7 @@ GITHUB_CLIENT_ID = 'TODO'
 GITHUB_CLIENT_SECRET = 'TODO'
 GITHUB_API_USER = 'TODO'
 GITHUB_API_TOKEN = 'TODO'
+GITHUB_APP_NAME = 'TODO'


GITHUB_API_BASE_URL
GITHUB_SCOPE

these should probably go in the .dist, no?

GITHUB_APP_NAME too

I was considering GITHUB_SCOPE, GITHUB_API_BASE_URL, and GITHUB_TOKEN_URL to be more repo specific than local dev specific. Realistically, I could eliminate the api/token urls since they shouldn't change. Scope would only change if the project as a whole was changing to require more permissions from the user (so a dev would want to commit that change in order to allow any added functionality to work for everyone). Do you want me to move them?

owocki · 2017-12-22T19:26:36Z

app/assets/v2/js/pages/bounty_details.js

+                        } else {
+                            var entry = {
+                                href: '/interested',
+                                text: 'Express Interest',


seems like if i am not authenticated, this (and remove interest above) should present the user with a dialog asking them to login, no? http://bits.owocki.com/3z0K3v0r3c1c/Screen%20Recording%202017-12-22%20at%2012.26%20PM.gif

Whoops! I'll push a fix for this shortly.

owocki · 2017-12-22T19:33:14Z

app/assets/v2/js/pages/bounty_details.js

@@ -337,12 +340,30 @@ window.addEventListener('load', function() {
                    actions.push(entry);
                    if(result['status']=='open' && !isBountyOwner(result) ){
                        var entry = {
-                            href: '/funding/claim?source='+result['github_url'],
+                            href: '/_github/auth?redirect_uri=/funding/claim?source=' + result['github_url'],


it'd be great if the username was prefilled after i got to this page http://bits.owocki.com/2M3U3m3n0k29/Screen%20Shot%202017-12-22%20at%2012.32.53%20PM.png

(claim page)

This was an oversight on my part. I'll add that.

owocki · 2017-12-22T19:35:17Z

app/assets/v2/js/pages/bounty_details.js

+                            var entry = {
+                                href: '/uninterested',
+                                text: 'Remove Interest',
+                                parent: 'right_actions',


two things

it'd be great if 'interested profiles updated AJAX'ily when i added / removed my interest

not sure how much thought was put into the design here.. ( i can ask someone who does design to look into it if we want).. but maybe for now we can just remove the list bullet?

Good point. I didn't add any method of updating the view with the current user after they express interest... Sorry about that.

owocki · 2017-12-22T19:38:13Z

app/dashboard/models.py

+        return 'https://api.github.com/repos/' + url_path
+
+    def fetch_issue_item(self, item_type='body'):
+        """Fetch the item type of an issue.


nice little refactor :)

owocki · 2017-12-22T19:40:53Z

app/dashboard/templates/bounty_details.html

@@ -75,6 +75,22 @@ <h5>Claimee Info</h5>
                            Github Profile: <span id="claimee_github_username"></span>

                        </div>
+                        <div id="interest_list">
+                            <br>
+                            <h5>Interested Profiles</h5>


if we ever decide to do this with javascript, theres some examples if you search text/x-jsrender

That makes sense. I tend to drink the django kool-aid when it comes to handling data interaction with the template.

owocki · 2017-12-22T19:41:40Z

app/dashboard/templates/yge/send2.html

@@ -55,11 +55,11 @@ <h1>Send Tip.</h1>
            </div>
            <div>
                From Name (optional):
-                <input type="text" placeholder="Bobby Tables" id="fromName" value="" style="width: 400px; margin-left: auto; margin-right: auto;">
+                <input type="text" placeholder="Bobby Tables" id="fromName" value="{% if from_handle %}{{ from_handle }}{% endif %}" style="width: 400px; margin-left: auto; margin-right: auto;">


strangely enough.. i cant get this information to prepopulate after i auth with github.. wonder what im doing wrong

I'll take a look when I'm going the refactor and include setup steps/gifs of functionality.

owocki · 2017-12-22T19:43:11Z

app/dashboard/views.py

@@ -40,8 +44,53 @@
 confirm_time_minutes_target = 3


-def send_tip(request):
+@require_GET
+def github_callback(request):


i haven't been horribly consistent about this myself... so take with a grain of salt.. but it could be worht moving all the github auth views into their own view file

I agree. I originally added an app specifically for this, but figured it should conform to the rest of the project for the moment. 😂 I'll move it over to it's own app.

owocki · 2017-12-27T16:30:27Z

donno if you're on the grid this week (some are, some arent) so no pressure if not.. but im antsy to see this move forward! let me know when to expect another pass

mbeacom · 2017-12-27T16:38:03Z

@owocki The holidays have set me back on this a bit. Mostly been keeping updated on GH from my phone, but I should have the updates in today. I'll ping you once they're in.

owocki · 2017-12-28T22:13:48Z

kk np

owocki · 2018-01-02T16:59:54Z

happy new year! let me know what your new schedule looks like here...

also, mind resolving the merge conflcits?

kamescg · 2018-01-08T16:44:08Z

@owocki thanks for sharing the link in the Slack focus-dev-general channel

Want to join the discussion and open up the possibility of using uPort and self-sovereign identity systems as the consistent identifier within the Gitcoin ecosystem.

Additionally, we could have participants "attest" to their Github account, make a clear link between self-sovereign identity and third-parties (github, twitter, etc...), but still maintaining a decentralized foundation.

The added benefit of using uPort might be easily associated wallet address, verifiable voting capabilities, and additional features like badges and accomplishments.

owocki · 2018-01-12T20:32:11Z

Want to join the discussion and open up the possibility of using uPort and self-sovereign identity systems as the consistent identifier within the Gitcoin ecosystem.

its something we should consider.. but is probably out of scope of this PR @kamescg -- could you start another issue and lets discuss what youre thinking!?

owocki · 2018-01-15T02:29:12Z

per https://gitcoincommunity.slack.com/archives/C7A4F4UHK/p1515876720000097 i wonder if we should rename 'express interest' into claim work and the current claim functionality to 'claim funds'.

Claim Work: you’ve claimed it and going to do it
Claim Bounty: like a bounty hunter you take the bounty to find the person and bring them in. Also you might not be able to finish it, for whatever reason so you “sell” it to someone else, or you need help so you split the bounty with another hunter to help. So I think in a deeper thought and probably stretching for meaning here lol I’m going with Claim Bounty

owocki · 2018-01-16T23:47:55Z

closing this as it's been moved over to january2018_feature_integration

owocki · 2018-01-17T01:51:48Z

hey @mbeacom it looks like most of my feedback above isnt turned around.. do you want to move it over to https://github.com/gitcoinco/web/projects/1 or just turn it around on the new branch?

mbeacom · 2018-01-17T15:45:59Z

@owocki I moved the remaining issues over to the project yesterday evening. I'll move any additional notes on the new PR over to GH project cards.

stewards update

mbeacom added 2 commits December 20, 2017 19:45

Ref #98 Ref #62 - GH integrations and express interest

572eadd

Fix unsorted import

4570a36

owocki reviewed Dec 22, 2017

View reviewed changes

owocki mentioned this pull request Dec 27, 2017

scaling the claiming of bounties as the community grows #130

Closed

owocki mentioned this pull request Dec 28, 2017

Code Faucet Page #184

Closed

This was referenced Dec 29, 2017

link profile in nav somewhere #191

Closed

interaction between different levels of expressed interest on an issue. gitcoinco/gitcoinco#16

Closed

interaction / distribution of funds between different levels of interest on an issue. #193

Closed

Merge remote-tracking branch 'upstream/master' into gh-int-express-int

040e018

mbeacom mentioned this pull request Jan 7, 2018

backend db & API support to show how many comments exist for an issue #219

Merged

3 tasks

owocki mentioned this pull request Jan 12, 2018

Allow users to view their tips / bounties on the web. #141

Closed

mbeacom mentioned this pull request Jan 15, 2018

(WIP) January 2018 Multiple Integrations #240

Merged

3 tasks

owocki closed this Jan 16, 2018

mbeacom deleted the gh-int-express-int branch March 2, 2018 06:03

owocki pushed a commit that referenced this pull request Apr 30, 2021

Merge pull request #156 from nopslip/QL2_richard_frontend

7612530

stewards update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH integration and express interest #156

GH integration and express interest #156

mbeacom commented Dec 21, 2017

codecov bot commented Dec 21, 2017 •

edited

Loading

owocki commented Dec 22, 2017

owocki Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki Dec 22, 2017

mbeacom Dec 22, 2017

owocki commented Dec 27, 2017

mbeacom commented Dec 27, 2017

owocki commented Dec 28, 2017

owocki commented Jan 2, 2018

kamescg commented Jan 8, 2018

owocki commented Jan 12, 2018

owocki commented Jan 15, 2018 •

edited

Loading

owocki commented Jan 16, 2018

owocki commented Jan 17, 2018

mbeacom commented Jan 17, 2018

GH integration and express interest #156

GH integration and express interest #156

Conversation

mbeacom commented Dec 21, 2017

Description

Checklist

Affected core subsystem(s)

Refers/Fixes

codecov bot commented Dec 21, 2017 • edited Loading

Codecov Report

owocki commented Dec 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Dec 27, 2017

mbeacom commented Dec 27, 2017

owocki commented Dec 28, 2017

owocki commented Jan 2, 2018

kamescg commented Jan 8, 2018

owocki commented Jan 12, 2018

owocki commented Jan 15, 2018 • edited Loading

owocki commented Jan 16, 2018

owocki commented Jan 17, 2018

mbeacom commented Jan 17, 2018

codecov bot commented Dec 21, 2017 •

edited

Loading

owocki commented Jan 15, 2018 •

edited

Loading