Code Faucet Page #184

owocki · 2017-12-28T21:02:36Z

Spec

Very often, I get people who want to claim an issue on Gitcoin but can't because they don't have ETH. Either there are no exchanges in their area, or they dont have the mone yto spend on gas.

Pursuant to making ethereum and Gitcoin accessible to everyone as broadly as possible, I would like to design a page entitled 'faucet' in which a user can go to the page and submit an application to receive a small amount of ETH.

Functional spec:

Design ( Design: Faucet page #173 (comment) ) will be responsive
All inputs are required.
Form input Email address should be validated to be an email
Form input ETH address should be prefilled with the users' metamask web3.eth.coinbase address, and should be validated as an ethereum address.
The form should not allow users to submit more than once per github account.
when the form is submitted a new row will be stored in FaucetApplication ( a new model)
when the form is submitted, an email will be sent to settings.SERVER_EMAIL notifying the admin of the faucet application.
the above email should have a link to a page in the admin which will allow the 'faucet' to be fulfilled
the page in the admin should show all fields from the form and have a 'fulfill' button which will trigger a 0.003 ETH payment to the ETH address, and then, upon success, mark the faucet object as fulfilled and send an email notifying the recipient that their faucet request has been funded.

New database model proposal

FaucetApplication
-pk

created_on
modified_on
fuilfilled (bool)
Github profile
ETH address
email address
comments
Github metadata

References

#173 (comment)
frontend design for this page: #184

Bounty

Please only claim this bounty if you can turn it around in the next 3 days.

The text was updated successfully, but these errors were encountered:

owocki · 2017-12-28T21:05:10Z

note: you may wish to rely on the github integration coded here #156

gitcoinbot · 2017-12-28T21:06:37Z

This issue now has a funding of 0.13 ETH (89.98 USD) attached to it.

If you would like to work on this issue you can claim it here.
If you've completed this issue and want to claim the bounty you can do so here
Questions? Get help on the Gitcoin Slack
$9963.55 more Funded OSS Work Available at: https://gitcoin.co/explorer

gitcoinbot · 2017-12-28T23:01:15Z

The funding of 0.13 ETH (89.98 USD) attached has been claimed by @usulix.

@usulix, please leave a comment to let the funder (@owocki) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.

Learn more on the gitcoin issue page
Questions? Get help on the Gitcoin Slack
$9963.55 more Funded OSS Work Available at: https://gitcoin.co/explorer

usulix · 2017-12-29T19:32:37Z

@owocki

I have web setup on my local from working on design: waiting room quote while page is waiting for web3 updates #181
I have the new route and page added - currently adding it to dashboard... but I could see how it might be better suited to retail... lmk, please, if you want it there instead
I will add form fields per the new model
I was planning to check that attached wallet balance is 0 (but maybe that should check for almost 0 instead ?)
I will check 1 faucet per github on Github profile change in the form
I will add model
I will hook into the settings.SERVER_EMAIL and send email (plain text ok?)
and I will build the admin page to process the faucet transaction based upon a settings.FAUCET_AMOUNT... currently set to .003
should the admin form be a list with the ability to filter for fulfilled, unfulfilled, or all and a button to fulfill unfulfilled ?.... or just one page with the new request ? and if we do one page.. how would you like to navigate to other requests ?

Thanks
G

owocki · 2017-12-29T20:02:15Z

but maybe that should check for almost 0 instead

yes pls

plain text ok?
yes

should the admin form be a list with the ability to filter for fulfilled, unfulfilled, or all and a button to fulfill unfulfilled ?...

you can use the default django admin view for the list.. copying some of the patteresn from tdi/admin.py#WhitepaperAccessRequest might be good too

usulix · 2017-12-29T20:23:42Z

@owocki
sounds great. will do.
re: "I have the new route and page added - currently adding it to dashboard... but I could see how it might be better suited to retail... lmk, please, if you want it there instead"
I am finding myself in need of slightly different errors for

{% include 'shared/no_metamask_error.html' %}
{% include 'shared/zero_balance_error.html' %}
{% include 'shared/unlock_metamask.html' %}

ie. for that error... "Thank you for your interest in receiving a faucet distribution, but you have more ether currently in your wallet than the distribution."

So, unless it is a problem, I am creating a new (ZF1 I would call it a module.. not sure about Django name for it) section under app with dashboard, marketing, retail.. etc called faucet... that way the views and models can be modular and contained there [while staying as DRY as possible, of course].. sound ok ?

owocki · 2017-12-29T20:33:51Z

yes that sounds right. you shouldnt need any of the shared/ partials for this view

usulix · 2017-12-30T00:03:05Z

@owocki - I see comments in the model... should that be an optional field on the form for users to put in something like "I am going to claim issue #184" ?... or is it for admin notes at some point ?

owocki · 2017-12-30T00:37:43Z

It’s for the former

On Fri, Dec 29, 2017 at 5:03 PM usulix ***@***.***> wrote: @owocki <https://github.com/owocki> - I see comments in the model... should that be an optional field on the form for users to put in something like "I am going to claim issue #184 <#184>" ?... or is it for admin notes at some point ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfXiaTs4v8Im20tguytuVXVFpCwilqnks5tFX25gaJpZM4ROpbt> .

-- @owocki <http://www.twitter.com/owocki>

…

_________________________________________ check out what i'm building on github <http://github.com/owocki> or what i'm shooting on photoshelter <http://photography.owocki.com/> or find me on twitter <http://www.twitter.com/owocki>, facebook <http://www.facebook.com/kevinowocki>, instagram <http://instagram.com/owocki>, linkedin <http://www.linkedin.com/in/owocki>, and owocki.com <http://www.owocki.com/?utm_source=emailsig>. see you around teh internets! PS -- Come to the next Boulder Blockchain <https://www.meetup.com/Boulder-Blockchain/> meetup. Be there or be ^ 2. PPS -- Have I mentioned that *G**itcoin is live?* More @ https://gitcoin.co

usulix · 2018-01-01T23:02:08Z

@owocki ,
Hi and Happy New Year.
I wanted to give you an update on this.
I have everything done except funding the request from the admin panel. I just realized that the contrib.admin uses much more of a request->page->request->page method than something that will allow easier interactions with w3.

I will need to take a look at the client side setup and add that to the template in admin. I have obligations Tuesday but should be able to finish Wednesday.

Regards,
G

owocki · 2018-01-02T02:29:12Z

thanks for the update..

request->page->request->page

i wonder if we could get around this with some simple javascript.. just something simple that submits the tx to web3 and submits the HTML form after it has.

vs77bb · 2018-01-09T18:28:39Z

Howdy @usulix, I joined @owocki at Gitcoin and am checking in here... how goes it?

owocki · 2018-01-09T18:59:52Z

i think i need to review @usulix 's PR :)

vs77bb · 2018-01-17T02:08:48Z

@owocki Did you get to this? An exciting feature worth a small content piece, whenever ready - IMHO :)

owocki · 2018-01-17T18:48:33Z

yes i am waiting on @usulix to turnaround my comments on the PR

owocki · 2018-01-25T17:16:57Z

per @usulix message on slack.. he is super busy at work and needs some help getting this across the finish line.. i need to confirm with him, but i think yall should split the ETH. anyone want? @ethikz @thelostone-mc ?

ethikz · 2018-01-25T23:54:11Z

I've added his repo as a remote and cloned it. Just trying to catch up on what's going. If @thelostone-mc gets to it before me then awesome, if not I'll let you know once I go through everything.

usulix · 2018-01-26T01:18:20Z

@ethikz thanks. and any questions, I can probably field a couple. as far as I recall... it is basically just in need of

change out the page markup for the ones provided on the other ticket Design: Faucet page #173 (comment)
run the github user check through github login instead (and maybe create a user profile in gitcoin)
tack on an email to the requester when admin funds the faucet request

thelostone-mc · 2018-01-26T01:32:17Z

@ethikz this one is yours!
I'm helping out with the redeem/coin page and catching up on reading up solidity + crypto-economics!
Ping me if you hit a roadblock, I'll help out. I can put some time aside to help out ^_^

ethikz · 2018-01-26T01:50:14Z

@usulix awesome! thanks for letting me know and saving me some more reading time lol. Hopefully, I won't have too many if any questions but I'll be sure to reach out if I do!

@thelostone-mc haha ok. I'll spend some time on it this weekend but will be traveling to multiple destinations for a bit so won't be able to really work on anything then.

ethikz · 2018-01-26T02:48:07Z

@usulix so the page /faucet needs to match the mockups at #173 (comment)

Am I understanding that correctly?

usulix · 2018-01-26T20:46:11Z

Yes, there are comps at https://github.com/gitcoinco/web/files/1599926/Gitcoin_Faucet.2.zip attached to that ticket

ethikz · 2018-01-26T21:27:55Z

The comps are different than the pages so I wanted to make sure before I started making all the UI changes lol.

Thanks!

usulix · 2018-02-01T03:51:38Z

It worked for me last time I ran it... No errors or oddities. I will check again this weekend and let you know if I get different results.

…

Sent from my iPhone

On Jan 31, 2018, at 7:44 AM, Josh Christensen ***@***.***> wrote: @usulix Did you run into an issue when running docker? print request.POST.get('destinationAccount') web_1 | ^ web_1 | SyntaxError: invalid syntax I fixed that by adding () around it but now there is another error File "/code/app/faucet/views.py", line 10, in <module> web_1 | from models import FaucetRequest web_1 | ModuleNotFoundError: No module named 'models' = — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ethikz · 2018-02-01T10:21:23Z

@usulix Are you on Gitcoin slack?

usulix · 2018-02-01T16:12:27Z

Occasionally...

…

Sent from my iPhone

On Feb 1, 2018, at 3:21 AM, Josh Christensen ***@***.***> wrote: @usulix Are you on Gitcoin slack? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ethikz · 2018-02-02T01:57:18Z

Oh ok, didn't find your username. So for sake of going back and forth can you just message me when you get on.

owocki · 2018-02-12T23:23:49Z

@vs77bb this might be a good one to promote via twitter to get folks to jump on it

@ethikz you still want it?

vs77bb · 2018-02-13T16:56:45Z

Done - https://twitter.com/GetGitcoin/status/963456837524828160

owocki · 2018-02-13T19:21:02Z

i moved this over to a new place => #407

once that scope is completed, i will pay out both bounties

usulix mentioned this issue Dec 29, 2017

design: waiting room quote while page is waiting for web3 updates #181

Closed

owocki mentioned this issue Dec 31, 2017

explore the idea of a gas faucet gitcoinco/skunkworks#10

Closed

usulix mentioned this issue Jan 3, 2018

(WIP) process faucet request #211

Closed

3 tasks

usulix mentioned this issue Jan 19, 2018

Faucet page #258

Closed

3 tasks

owocki mentioned this issue Feb 13, 2018

get Faucet Page across the finish line #407

Closed

4 tasks

owocki closed this as completed Feb 13, 2018

gitcoinco deleted a comment from gitcoinbot Feb 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code Faucet Page #184

Code Faucet Page #184

owocki commented Dec 28, 2017 •

edited

Loading

owocki commented Dec 28, 2017

gitcoinbot commented Dec 28, 2017

gitcoinbot commented Dec 28, 2017

usulix commented Dec 29, 2017

owocki commented Dec 29, 2017

usulix commented Dec 29, 2017

owocki commented Dec 29, 2017

usulix commented Dec 30, 2017

owocki commented Dec 30, 2017 via email

usulix commented Jan 1, 2018

owocki commented Jan 2, 2018

vs77bb commented Jan 9, 2018

owocki commented Jan 9, 2018

vs77bb commented Jan 17, 2018

owocki commented Jan 17, 2018

owocki commented Jan 25, 2018

ethikz commented Jan 25, 2018

usulix commented Jan 26, 2018

thelostone-mc commented Jan 26, 2018

ethikz commented Jan 26, 2018

ethikz commented Jan 26, 2018

usulix commented Jan 26, 2018

ethikz commented Jan 26, 2018

usulix commented Feb 1, 2018 via email

ethikz commented Feb 1, 2018

usulix commented Feb 1, 2018 via email

ethikz commented Feb 2, 2018

owocki commented Feb 12, 2018

vs77bb commented Feb 13, 2018

owocki commented Feb 13, 2018

Code Faucet Page #184

Code Faucet Page #184

Comments

owocki commented Dec 28, 2017 • edited Loading

Spec

New database model proposal

References

Bounty

owocki commented Dec 28, 2017

gitcoinbot commented Dec 28, 2017

gitcoinbot commented Dec 28, 2017

usulix commented Dec 29, 2017

owocki commented Dec 29, 2017

usulix commented Dec 29, 2017

owocki commented Dec 29, 2017

usulix commented Dec 30, 2017

owocki commented Dec 30, 2017 via email

usulix commented Jan 1, 2018

owocki commented Jan 2, 2018

vs77bb commented Jan 9, 2018

owocki commented Jan 9, 2018

vs77bb commented Jan 17, 2018

owocki commented Jan 17, 2018

owocki commented Jan 25, 2018

ethikz commented Jan 25, 2018

usulix commented Jan 26, 2018

thelostone-mc commented Jan 26, 2018

ethikz commented Jan 26, 2018

ethikz commented Jan 26, 2018

usulix commented Jan 26, 2018

ethikz commented Jan 26, 2018

usulix commented Feb 1, 2018 via email

ethikz commented Feb 1, 2018

usulix commented Feb 1, 2018 via email

ethikz commented Feb 2, 2018

owocki commented Feb 12, 2018

vs77bb commented Feb 13, 2018

owocki commented Feb 13, 2018

owocki commented Dec 28, 2017 •

edited

Loading