Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 ➡️ 5 #1007

Merged
merged 19 commits into from
Sep 9, 2021
Merged

4 ➡️ 5 #1007

merged 19 commits into from
Sep 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo4 to ign-gazebo5

Branch comparison: ign-gazebo5...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 14 commits August 11, 2021 18:28
@chapulina
🎈 3.9.0~pre2 (#967)
76c7b39 
Signed-off-by: Louise Poubel <[email protected]>
@iche033
Fix entity creation console msg (#972)
9691622 
Signed-off-by: Ian Chen <[email protected]>
@chapulina
Don't use $HOME on most tests (InternalFixture) (#971)
4a5a33d 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3 ➡️ 4
46a95e6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Updates when forward-porting to v4 (#973)
d00a48e 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Entity tree: prevent creation of repeated entity items (#974)
7d1a3e0 
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde
Removed unused variable in Shapes plugin (#984)
d468c05 
Signed-off-by: ahcorde <[email protected]>
@chapulina
🎈 3.9.0 (#976)
054ff12 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
👩‍🌾 Remove bitbucket-pipelines.yml (#991)
d94d585 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3 ➡️ 4 (#973)
9cafd6d 
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde
Improved doxygen (#996)
c625586 
* Improved doxygen

Signed-off-by: ahcorde <[email protected]>

* Improved docs

Signed-off-by: ahcorde <[email protected]>
@chapulina
Enable sensor metrics on example worlds (#982)
aede69c 
Signed-off-by: Louise Poubel <[email protected]>
@iche033
Remove extra xml version line in pendulum_links example world (#1002)
7b326dc 
Signed-off-by: Ian Chen <[email protected]>
@iche033
Fix selection buffer crash on resize (#969)
1e6a9d1 
Signed-off-by: Ian Chen <[email protected]>
@chapulina chapulina requested a review from azeey as a code owner September 3, 2021 23:34
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 4, 2021 •
edited
Loading

Codecov Report

Merging #1007 (de6676e) into ign-gazebo5 (ae8eb2e) will increase coverage by 0.44%.
The diff coverage is 42.10%.

❗ Current head de6676e differs from pull request most recent head 66bfbc6. Consider uploading reports for the commit 66bfbc6 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5    #1007      +/-   ##
===============================================
+ Coverage        66.65%   67.09%   +0.44%     
===============================================
  Files              247      243       -4     
  Lines            18900    18215     -685     
===============================================
- Hits             12598    12222     -376     
+ Misses            6302     5993     -309
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/ContactSensor.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (-2.64%) ⬇️
...nclude/ignition/gazebo/components/LogicalCamera.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <0.00%> (ø)
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a457d...66bfbc6. Read the comment docs.

@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@chapulina chapulina mentioned this pull request Sep 8, 2021
Closed
@chapulina
3 ➡️ 4 (#1017)
de6676e 
Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Sep 8, 2021
@chapulina
4 ➡️ 5 (#1007))
70afcb6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from iche033 as a code owner September 8, 2021 18:23
jennuine
jennuine approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ported the component inspector fix #1018 and removed an extra : that was causing compilation failures c8610f2

@chapulina
4 ➡️ 5 (#1007)
66bfbc6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge September 8, 2021 23:33
@chapulina chapulina merged commit f388d6e into ign-gazebo5 Sep 9, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch September 9, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @jennuine @iche033 @ahcorde