Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate XML tag in pendulum_links example world #1002

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 30, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

removes duplicate <?xml version="1.0" ?> line otherwise sdformat gives an error about parsing the SDF file

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033 iche033 requested a review from chapulina as a code owner August 30, 2021 23:29
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #1002 (b201684) into ign-gazebo3 (d9195c4) will increase coverage by 0.27%.
The diff coverage is 78.03%.

❗ Current head b201684 differs from pull request most recent head fec2c7c. Consider uploading reports for the commit fec2c7c to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1002      +/-   ##
===============================================
+ Coverage        77.56%   77.84%   +0.27%     
===============================================
  Files              208      221      +13     
  Lines            11385    12687    +1302     
===============================================
+ Hits              8831     9876    +1045     
- Misses            2554     2811     +257     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/ContactSensor.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...nclude/ignition/gazebo/components/LogicalCamera.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Sensor.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh 90.32% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <0.00%> (ø)
.../plugins/component_inspector/ComponentInspector.cc 8.58% <0.00%> (-0.90%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aede69c...fec2c7c. Read the comment docs.

@chapulina chapulina merged commit 7b326dc into ign-gazebo3 Aug 31, 2021
@chapulina chapulina deleted the fix_pendulum_links_world branch August 31, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants