Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msg in entity_creation example #972

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 13, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Minor fix to a msg in the entity_creation example.

The example spawns a spot light and a sphere using the createEntityFromStr function but that function always prints out Sphere was created : [1]. So modified msg to be generic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from chapulina as a code owner August 13, 2021 00:28
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 13, 2021
@iche033 iche033 changed the title Fix entity creation msg Fix msg in entity_creation example Aug 13, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@chapulina chapulina enabled auto-merge (squash) August 13, 2021 01:13
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #972 (48e2280) into ign-gazebo4 (fbe137e) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 48e2280 differs from pull request most recent head c50dc15. Consider uploading reports for the commit c50dc15 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #972      +/-   ##
===============================================
- Coverage        67.12%   67.09%   -0.04%     
===============================================
  Files              243      243              
  Lines            18207    18207              
===============================================
- Hits             12222    12216       -6     
- Misses            5985     5991       +6     
Impacted Files Coverage Δ
src/gui/plugins/entity_tree/EntityTree.cc 9.83% <0.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe137e...c50dc15. Read the comment docs.

@chapulina chapulina merged commit 9691622 into ign-gazebo4 Aug 13, 2021
@chapulina chapulina deleted the entity_creation_msg branch August 13, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants