Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 5 (main) #292

Merged
merged 12 commits into from
Sep 13, 2021
Merged

4 ➡️ 5 (main) #292

merged 12 commits into from
Sep 13, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-physics4 to main

Branch comparison: main...ign-physics4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

chapulina and others added 12 commits July 13, 2021 08:38
* 🎈 3.3.0

Signed-off-by: Louise Poubel <[email protected]>

* update date

Signed-off-by: Louise Poubel <[email protected]>
* Added DART feature for setting joint limits dynamically.

Signed-off-by: Martin Pecka <[email protected]>

* Make code compatible with older DART release (this commit can be reverted once newer DART is out).

Signed-off-by: Martin Pecka <[email protected]>

* Updated the number of models for test.

Signed-off-by: Martin Pecka <[email protected]>

* Apply suggestions from code review

Signed-off-by: Martin Pecka <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>

* Fixed issues from review.

Signed-off-by: Martin Pecka <[email protected]>

* Accomodate DART 6.9

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
… any effect. (#289)

* Calculate link velocities, fix updates for models

Signed-off-by: Luca Della Vedova <[email protected]>

* Add test for velocity loopback

Signed-off-by: Luca Della Vedova <[email protected]>

* Avoid pushing duplicated links, change variable name

Signed-off-by: Luca Della Vedova <[email protected]>
Since joints in DART are not considered frames, this adds dart::dynamics::SimpleFrame attached to the child body of a joint and offset from the child by the pose of the joint.

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #292 (b3fe9d8) into main (32de314) will decrease coverage by 0.10%.
The diff coverage is 71.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   75.62%   75.52%   -0.11%     
==========================================
  Files         127      127              
  Lines        5473     5597     +124     
==========================================
+ Hits         4139     4227      +88     
- Misses       1334     1370      +36     
Impacted Files Coverage Δ
dartsim/src/JointFeatures.cc 63.56% <49.18%> (-4.46%) ⬇️
dartsim/src/KinematicsFeatures.cc 72.00% <50.00%> (-11.34%) ⬇️
tpe/plugin/src/SimulationFeatures.cc 82.71% <95.83%> (+4.38%) ⬆️
dartsim/src/Base.hh 97.97% <100.00%> (+0.05%) ⬆️
include/ignition/physics/detail/Joint.hh 100.00% <100.00%> (ø)
tpe/plugin/src/KinematicsFeatures.cc 70.00% <100.00%> (+9.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32de314...b3fe9d8. Read the comment docs.

@chapulina chapulina merged commit 45b52a4 into main Sep 13, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch September 13, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants