Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 ➡️ 3 #290

Merged
merged 4 commits into from
Sep 9, 2021
Merged

2 ➡️ 3 #290

merged 4 commits into from
Sep 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-physics2 to ign-physics3

Branch comparison: ign-physics3...ign-physics2

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

scpeters and others added 4 commits August 3, 2021 10:27
@scpeters
Add azeey and scpeters as code owners (#281)
065f895 
Signed-off-by: Steve Peters <[email protected]>
@chapulina
👩‍🌾 Remove bitbucket-pipelines.yml (#287)
347f082 
Signed-off-by: Louise Poubel <[email protected]>
@azeey @scpeters
[dartsim] Add support for joint frame semantics (#288)
f1aee5a 
Since joints in DART are not considered frames, this adds dart::dynamics::SimpleFrame attached to the child body of a joint and offset from the child by the pose of the joint.

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@chapulina
2 ➡️ 3
a715965 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mxgrey as a code owner September 8, 2021 16:20
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #290 (2fdfc55) into ign-physics3 (55a4901) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 2fdfc55 differs from pull request most recent head a715965. Consider uploading reports for the commit a715965 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics3     #290      +/-   ##
================================================
- Coverage         74.43%   74.41%   -0.03%     
================================================
  Files               115      115              
  Lines              4788     4799      +11     
================================================
+ Hits               3564     3571       +7     
- Misses             1224     1228       +4
Impacted Files Coverage Δ
dartsim/src/KinematicsFeatures.cc 72.00% <50.00%> (-11.34%) ⬇️
dartsim/src/Base.hh 99.01% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a4901...a715965. Read the comment docs.

@chapulina chapulina mentioned this pull request Sep 8, 2021
Closed
@chapulina chapulina merged commit 0a1f08d into ign-physics3 Sep 9, 2021
@chapulina chapulina deleted the chapulina/2_to_3 branch September 9, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey mxgrey is a code owner

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @azeey @scpeters