Firestore Swift Cpp Experiment #13956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 68bf0dc [BUILD ERROR] FirebaseFirestoreInternal[BUILD ERROR] FirebaseFirestoreFirebaseCoreFunctions[MODIFIED] FIRFirebaseVersion[MODIFIED] FIRFirebaseVersionSwift:
+ func FirebaseVersion () -> String
- func FirebaseVersion () -> String
Objective-C:
+ NS_SWIFT_NAME ( FirebaseVersion ()) NSString * FIRFirebaseVersion ( void )
- NSString * _Nonnull FIRFirebaseVersion ( void ) |
cherylEnkidu
force-pushed
the
cheryllin/firestoreSwiftCpp
branch
from
4a5f5fd to
7c7ac2e
Compare
paulb777
reviewed
Oct 29, 2024
FirebaseFirestore.podspec
Outdated
| s.public_header_files = 'FirebaseFirestoreInternal/**/*.h' | ||
| s.public_header_files = [ | ||
| 'FirebaseFirestoreInternal/**/*.h', | ||
| 'Firestore/Swift/Source/SwiftAPI/*.swift', |
There was a problem hiding this comment.
Swift files should not be in the headers
cherylEnkidu
force-pushed
the
cheryllin/firestoreSwiftCpp
branch
from
4af3d5b to
497cbf8
Compare
This reverts commit 4164fb9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is inside this PR:
Add new cpp files inside
Firestore/core/swift/which is not included in existingPackage.swiftbuilding directory.Create a new cpp target library
FirebaseFirestoreCpp