Skip to content

Commit

Permalink
use @_implementationOnly
Browse files Browse the repository at this point in the history
  • Loading branch information
cherylEnkidu committed Nov 11, 2024
1 parent ec7848e commit 4164fb9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
*/

#if SWIFT_PACKAGE
@_exported import FirebaseFirestoreCpp
@_implementationOnly import FirebaseFirestoreCpp
#endif // SWIFT_PACKAGE

public class SwiftCallingCpp {
public init(_ value: String) {
public static func print(_ value: String) {
CppInterfaceCalledBySwift.print(std.string(value))

Check failure on line 23 in Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift

View workflow job for this annotation

GitHub Actions / platforms (catalyst)

no exact matches in call to initializer

Check failure on line 23 in Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift

View workflow job for this annotation

GitHub Actions / platforms (catalyst)

no exact matches in call to initializer
}
}
10 changes: 2 additions & 8 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -476,10 +476,7 @@ let package = Package(
dependencies: [
"FirebaseFirestoreTarget",
],
path: "FirebaseCombineSwift/Sources/Firestore",
swiftSettings: [
.interoperabilityMode(.Cxx), // C++ interoperability setting
]
path: "FirebaseCombineSwift/Sources/Firestore"
),
.target(
name: "FirebaseStorageCombineSwift",
Expand Down Expand Up @@ -1174,10 +1171,7 @@ let package = Package(
"FirebaseStorage",
.product(name: "nanopb", package: "nanopb"),
],
path: "SwiftPMTests/swift-test",
swiftSettings: [
.interoperabilityMode(.Cxx), // C++ interoperability setting
]
path: "SwiftPMTests/swift-test"
),
.testTarget(
name: "analytics-import-test",
Expand Down

0 comments on commit 4164fb9

Please sign in to comment.