-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore Swift Cpp Experiment #13956
Open
cherylEnkidu
wants to merge
15
commits into
main
Choose a base branch
from
cheryllin/firestoreSwiftCpp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bf1f630
init
cherylEnkidu b84f3ec
bug fix
cherylEnkidu 7c7ac2e
add extern c
cherylEnkidu 65931e7
public init
cherylEnkidu b7f7ebc
Add cocoapods support (broken)
cherylEnkidu 8f13ade
Remove swift file in public header
cherylEnkidu 456ed82
Fix cocoapods
cherylEnkidu 497cbf8
Fix style
cherylEnkidu 299de31
simplify cocoapods
cherylEnkidu ec7848e
Add Objective-C version
cherylEnkidu 4164fb9
use @_implementationOnly
cherylEnkidu e31679f
Revert "use @_implementationOnly"
cherylEnkidu 681f6b3
implement pipeline files in C++ side
cherylEnkidu f0288cd
add pipeline interface in cocoapods support
cherylEnkidu 92d1380
add pipeline result
cherylEnkidu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
Pod::Spec.new do |s| | ||
s.name = 'FirebaseFirestoreCpp' | ||
s.version = '11.5.0' | ||
s.summary = 'Google Cloud Firestore' | ||
|
||
s.description = <<-DESC | ||
Google Cloud Firestore is a NoSQL document database built for automatic scaling, high performance, and ease of application development. | ||
DESC | ||
|
||
s.homepage = 'https://developers.google.com/' | ||
s.license = { :type => 'Apache-2.0', :file => 'Firestore/LICENSE' } | ||
s.authors = 'Google, Inc.' | ||
|
||
s.source = { | ||
:git => 'https://github.com/firebase/firebase-ios-sdk.git', | ||
:tag => 'CocoaPods-' + s.version.to_s | ||
} | ||
|
||
s.ios.deployment_target = '13.0' | ||
s.osx.deployment_target = '10.15' | ||
s.tvos.deployment_target = '13.0' | ||
|
||
s.swift_version = '5.9' | ||
|
||
s.cocoapods_version = '>= 1.12.0' | ||
s.prefix_header_file = false | ||
|
||
s.public_header_files = 'Firestore/core/swift/umbrella/*.h' | ||
|
||
s.source_files = [ | ||
'Firestore/core/swift/**/*.{cc,h}' | ||
] | ||
|
||
abseil_version = '~> 1.20240116.1' | ||
s.dependency 'abseil/algorithm', abseil_version | ||
s.dependency 'abseil/base', abseil_version | ||
s.dependency 'abseil/container/flat_hash_map', abseil_version | ||
s.dependency 'abseil/memory', abseil_version | ||
s.dependency 'abseil/meta', abseil_version | ||
s.dependency 'abseil/strings/strings', abseil_version | ||
s.dependency 'abseil/time', abseil_version | ||
s.dependency 'abseil/types', abseil_version | ||
|
||
s.ios.frameworks = 'SystemConfiguration', 'UIKit' | ||
s.osx.frameworks = 'SystemConfiguration' | ||
s.tvos.frameworks = 'SystemConfiguration', 'UIKit' | ||
|
||
s.library = 'c++' | ||
s.pod_target_xcconfig = { | ||
'CLANG_CXX_LANGUAGE_STANDARD' => 'c++14', | ||
'CLANG_CXX_LIBRARY' => 'libc++', | ||
'GCC_C_LANGUAGE_STANDARD' => 'c99', | ||
'GCC_PREPROCESSOR_DEFINITIONS' => | ||
"FIRFirestore_VERSION=#{s.version} " + | ||
# The nanopb pod sets these defs, so we must too. (We *do* require 16bit | ||
# (or larger) fields, so we'd have to set at least PB_FIELD_16BIT | ||
# anyways.) | ||
'PB_FIELD_32BIT=1 PB_NO_PACKED_STRUCTS=1 PB_ENABLE_MALLOC=1', | ||
'HEADER_SEARCH_PATHS' => | ||
'"${PODS_TARGET_SRCROOT}" ' + | ||
'"${PODS_TARGET_SRCROOT}/Firestore/core/swift/include" ' | ||
} | ||
|
||
s.compiler_flags = '$(inherited) -Wreorder -Werror=reorder -Wno-comma' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// | ||
// SwiftCppAPI.swift | ||
// Firebase | ||
// | ||
// Created by Cheryl Lin on 2024-10-22. | ||
// | ||
|
||
import FirebaseFirestoreCpp | ||
|
||
public class SwiftCppWrapper { | ||
public init(_ value : String ){ | ||
_ = UsedBySwift(std.string(value)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// | ||
// Created by Cheryl Lin on 2024-10-22. | ||
// | ||
|
||
#ifndef FIREBASE_USED_BY_SWIFT_H | ||
#define FIREBASE_USED_BY_SWIFT_H | ||
|
||
#include <string> | ||
|
||
class UsedBySwift { | ||
public: | ||
explicit UsedBySwift(std::string content); | ||
}; | ||
|
||
#endif // FIREBASE_USED_BY_SWIFT_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// | ||
// Created by Cheryl Lin on 2024-10-22. | ||
// | ||
|
||
#include "../include/used_by_swift.h" | ||
#include <iostream> | ||
|
||
UsedBySwift::UsedBySwift(std::string content) { | ||
std::cout << "ctor runs with value: " << content << std::endl; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// | ||
// Created by Cheryl Lin on 2024-10-22. | ||
// | ||
|
||
#ifndef FIREBASE_FIREBASEFIRESTORECPP_H | ||
#define FIREBASE_FIREBASEFIRESTORECPP_H | ||
|
||
#import "../include/used_by_swift.h" | ||
|
||
#endif // FIREBASE_FIREBASEFIRESTORECPP_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swift files should not be in the headers