Remove unstable scheduler/tracing API #20037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9bd8867:
|
|
Comparing: 84b9162...104fdc5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Details of bundled changes.Comparing: c57fe4a...9bd8867 react-dom
react-art
react
react-reconciler
react-test-renderer
react-native-renderer
ReactDOM: size: 0.0%, gzip: 0.0% React: size: -2.8%, gzip: -1.9% Size changes (experimental) |
|
Is it worth implementing a much scaled down version of tracing that is React-specific (doesn’t try to wrap non-React APIs) and never cascades (so the implementation complexity is low and interactions don’t leak into unrelated cascading commits)? |
|
I appreciate this PR. I hear you loud and clear. Let's discuss what remaining features are useful and how else we can solve them. |
|
Sure. Had this as a topic for the sync today but forgot you wouldn't be at this one. Moved it to next week. Happy to chat out of band too if that' easier. Maybe there's a trimmed down version that would be worth keeping. |
bvaughn
changed the title
bvaughn
force-pushed
the
remove-scheduler-tracing
branch
from
9bd8867 to
28d1504
Compare
|
Rebased this and it's ready to review. |
bvaughn
force-pushed
the
remove-scheduler-tracing
branch
from
28d1504 to
6523863
Compare
|
I'm not sure how to mock the jest.mock('scheduler', () => jest.requireActual('scheduler-0-13'));
jest.mock('scheduler/tracing', () => jest.requireActual('scheduler-0-13/tracing'));
jest.mock('react', () => jest.requireActual('react-16-8'));
jest.mock('react-dom', () => jest.requireActual('react-dom-16-8'));But Jest throws because there isn't an actual "scheduler/tracing" module installed locally. Edit The answer was to also add a dummy file in |
bvaughn
force-pushed
the
remove-scheduler-tracing
branch
from
df91387 to
1897759
Compare
acdlite
approved these changes
Apr 21, 2021
bvaughn
force-pushed
the
remove-scheduler-tracing
branch
from
1897759 to
104fdc5
Compare
|
D28001916 shows (what I believe to be) a successful merge of this change (with all e2e and unit tests passing) so... let's go! |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 28, 2021
Summary: This sync includes the following changes: - **[9a2591681](facebook/react@9a2591681 )**: Fix export //<Sebastian Markbage>// - **[4a8deb083](facebook/react@4a8deb083 )**: Switch the isPrimaryRender flag based on the stream config ([#21357](facebook/react#21357)) //<Sebastian Markbåge>// - **[bd4f056a3](facebook/react@bd4f056a3 )**: [Fizz] Implement lazy components and nodes ([#21355](facebook/react#21355)) //<Sebastian Markbåge>// - **[fc33f12bd](facebook/react@fc33f12bd )**: Remove unstable scheduler/tracing API ([#20037](facebook/react#20037)) //<Brian Vaughn>// - **[721238394](facebook/react@721238394 )**: Enable strict effects mode for React Native Facebook builds ([#21354](facebook/react#21354)) //<Brian Vaughn>// - **[48740429b](facebook/react@48740429b )**: Expiration: Do nothing except disable time slicing ([#21345](facebook/react#21345)) //<Andrew Clark>// - **[0f5ebf366](facebook/react@0f5ebf366 )**: Delete unreferenced type ([#21343](facebook/react#21343)) //<Andrew Clark>// - **[9cd52b27f](facebook/react@9cd52b27f )**: Restore context after an error happens ([#21341](facebook/react#21341)) //<Sebastian Markbåge>// - **[ad091759a](facebook/react@ad091759a )**: Revert "Emit reactroot attribute on the first element we discover ([#21154](facebook/react#21154))" ([#21340](facebook/react#21340)) //<Sebastian Markbåge>// - **[709f94841](facebook/react@709f94841 )**: [Fizz] Add FB specific streaming API and build ([#21337](facebook/react#21337)) //<Sebastian Markbåge>// - **[e8cdce40d](facebook/react@e8cdce40d )**: Don't flush sync at end of discreteUpdates ([#21327](facebook/react#21327)) //<Andrew Clark>// - **[a15586001](facebook/react@a15586001 )**: Fix: Don't flush discrete at end of batchedUpdates ([#21229](facebook/react#21229)) //<Andrew Clark>// - **[89847bf6e](facebook/react@89847bf6e )**: Continuous updates should interrupt transitions ([#21323](facebook/react#21323)) //<Andrew Clark>// - **[ef37d55b6](facebook/react@ef37d55b6 )**: Use performConcurrentWorkOnRoot for "sync default" ([#21322](facebook/react#21322)) //<Andrew Clark>// Changelog: [General][Changed] - React Native sync for revisions a632f7d...2a7bb41 jest_e2e[run_all_tests] Reviewed By: JoshuaGross Differential Revision: D28063006 fbshipit-source-id: 7e3535f80961706863b6c2188ee44b5796b2f000
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
jordanhennell
added a commit
to jordanhennell/event-reduce
that referenced
this pull request
Jun 6, 2022
Was removed in React 17 facebook/react#20037
Closed
markerikson
added a commit
to replayio/react
that referenced
this pull request
Mar 20, 2023
This was added as part of the "Interaction Tracking" work in facebook#13509 back in 2018. That feature was removed in facebook#20037 in 2020, and this plugin appears to no longer have any effect on the build output.
markerikson
added a commit
to replayio/react
that referenced
this pull request
Mar 20, 2023
This was added as part of the "Interaction Tracking" work in facebook#13509 back in 2018. That feature was removed in facebook#20037 in 2020, and this plugin appears to no longer have any effect on the build output.
markerikson
added a commit
to replayio/react
that referenced
this pull request
Mar 20, 2023
This was added as part of the "Interaction Tracking" work in facebook#13509 back in 2018. That feature was removed in facebook#20037 in 2020, and this plugin appears to no longer have any effect on the build output.
markerikson
added a commit
to replayio/react
that referenced
this pull request
Mar 20, 2023
This was added as part of the "Interaction Tracking" work in facebook#13509 back in 2018. That feature was removed in facebook#20037 in 2020, and this plugin appears to no longer have any effect on the build output.
markerikson
added a commit
to replayio/react
that referenced
this pull request
Mar 20, 2023
This was added as part of the "Interaction Tracking" work in facebook#13509 back in 2018. That feature was removed in facebook#20037 in 2020, and this plugin appears to no longer have any effect on the build output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21285
Going to be easier to review this one with whitespace hidden: https://github.com/facebook/react/pull/20037/files?w=1
Mostly just a bunch of deletions. Code to look at a little more closely:
packages/react-reconciler/src/ReactFiberWorkLoop.new.jsTesting this change internally via D28001916. Note that to sync to www after this change, we'll need to delete:
html/shared/node_modules/scheduler/tracing.jshtml/shared/react-fb/SchedulerTracing.jsWe'll want to update our JS1 sync script to remove the following files:
'SchedulerTracing-dev.modern.js''SchedulerTracing-prod.modern.js''SchedulerTracing-profiling.modern.js'We'll also want to update the following file to remove references to Profiler interactions and add a DEV console warning if the
onlyLogInteractionsoption is provided:html/intern/js/coreviz/react_profiler/createCoreVizOnRenderCallback.js