Remove PropTypes from InspectorOverlay

[kdastan]

Related to #21342

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

eslint found some issues. You may run yarn prettier or npm run prettier to fix these.

[analysis-bot]

Cannot get StyleSheet.Styles because property Styles is missing in object literal [1].

[pull-bot]

	Warnings
⚠️	📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️	📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

[kdastan]

@empyrical is it ok, if I leave frame as Object and style as any?

[empyrical]

You should type style as ViewStyleProp, which you can import like this:

import type {ViewStyleProp} from 'StyleSheet';

You should be able to leave the type of frame as Object for now. Filling this out this will require filling out the types of ElementBox too, which is out of the scope of this pull request.

[kdastan]

@empyrical got it, thanks!

[empyrical]

LGTM 👍

[elicwhite]

Thanks for contributing! I can't import this because you don't have a valid CLA on file. You can follow the instructions from the facebook bot in this comment to complete the CLA

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[elicwhite]

Let's make these nullable either. The goal of nullable props is so that a component can take optional props and pass them to another component which takes the optional prop.

[kdastan]

Should I make Props nullable?

type Props = ?$ReadOnly<{| ...

do not quite understand

[elicwhite]

I'm looking for:

inspected?: {
  frame?: Object 
  style?: ViewStyleProp
}

Although inspected should also use $ReadOnly<{||}>. So:

inspected?: $ReadOnly<{|
  frame?: Object 
  style?: ViewStyleProp
|}>

[kdastan]

I created new Type, then used it as type of inspected

type Inspected = $ReadOnly<{|
  frame?: Object,
  style?: ViewStyleProp,
|}>;

[facebook-github-bot]

TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

@kdastan merged commit 9f8fc8f into facebook:master.

---

Once this commit is added to a release, you will see the corresponding version tag below the description at 9f8fc8f. If the commit has a single master tag, it is not yet part of a release.

[elicwhite]

Thanks for contributing!