Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify remaining unprettified files #21327

Closed
wants to merge 1 commit into from

Conversation

empyrical
Copy link
Contributor

This PR is the result of running yarn prettify on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs.

Test Plan:

No behaviour was changed.

Release Notes:

Help reviewers and the release process by writing your own release notes. See below for an example.

[GENERAL] [MINOR] [Libraries/Components/ScrollView/ScrollView.js] - Prettified
[GENERAL] [MINOR] [Libraries/Components/TextInput/TextInput.js] - Prettified
[GENERAL] [MINOR] [Libraries/Image/Image.ios.js] - Prettified
[GENERAL] [MINOR] [RNTester/js/ImageExample.js] - Prettified
[GENERAL] [MINOR] [flow/jest.js] - Prettified
[GENERAL] [MINOR] [local-cli/bundle/tests/getAssetDestPathAndroid-test.js] - Prettified
[GENERAL] [MINOR] [local-cli/bundle/tests/getAssetDestPathIOS-test.js] - Prettified
[GENERAL] [MINOR] [local-cli/generator/templates.js] - Prettified
[GENERAL] [MINOR] [local-cli/init/init.js] - Prettified

@empyrical empyrical requested a review from shergin as a code owner September 26, 2018 01:30
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2018
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint found some issues. You may run yarn prettier or npm run prettier to fix these.

}]}
style={[
styles.base,
styles.leftMargin,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native/no-inline-styles: Inline style: { borderWidth: 10,
borderTopLeftRadius: 10,
borderBottomRightRadius: 20,
borderColor: 'green' }

}]}
style={[
styles.base,
styles.leftMargin,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native/no-inline-styles: Inline style: { borderWidth: 5,
borderTopLeftRadius: 10,
borderTopRightRadius: 20,
borderBottomRightRadius: 30,
borderBottomLeftRadius: 40,
borderColor: 'red' }

@pull-bot
Copy link

Warnings
⚠️

❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 801 lines.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 26, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@empyrical merged commit 2da60a8 into facebook:master.


Once this commit is added to a release, you will see the corresponding version tag below the description at 2da60a8. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 26, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 26, 2018
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
This PR is the result of running `yarn prettify` on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs.
Pull Request resolved: facebook/react-native#21327

Differential Revision: D10046057

Pulled By: TheSavior

fbshipit-source-id: 2c771a3c758c72816c707e32ee2f4587e466f277
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Apr 14, 2019
Summary:
This PR is the result of running `yarn prettify` on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs.
Pull Request resolved: facebook/react-native#21327

Differential Revision: D10046057

Pulled By: TheSavior

fbshipit-source-id: 2c771a3c758c72816c707e32ee2f4587e466f277
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
This PR is the result of running `yarn prettify` on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs.
Pull Request resolved: facebook#21327

Differential Revision: D10046057

Pulled By: TheSavior

fbshipit-source-id: 2c771a3c758c72816c707e32ee2f4587e466f277
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants