Fix Cocoapods for Xcode 14.3.0 #36759

cipolleschi · 2023-04-01T10:33:43Z

Summary:
On Thursday the 30th, Apple Released Xcode 14.3.0.
This Version of Xcode enforce some version checks for which React-Codegen, which supported iOS 11 as minimum supported version, could not be build anymore.

This change ensue that React-Codegen is always aligned to the min version supported by React Native.
Plus, it moves CircleCI's Xcode to 14.3.0, to keep this problem in Check.

While working on this, I figured that, with the monorepo, Ruby tests stopped working because they were in the wrong folder: I moved them in the right one.

Changelog:

[iOS][Fixed] - Make React Native build with Xcode 14.3.0 and fix tests

Differential Revision: D44605617

facebook-github-bot · 2023-04-01T10:34:16Z

This pull request was exported from Phabricator. Differential Revision: D44605617

analysis-bot · 2023-04-01T10:59:34Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,569,009	+0
android	hermes	armeabi-v7a	7,883,400	+0
android	hermes	x86	9,050,927	+0
android	hermes	x86_64	8,905,954	+0
android	jsc	arm64-v8a	9,167,731	+0
android	jsc	armeabi-v7a	8,358,132	+0
android	jsc	x86	9,224,398	+0
android	jsc	x86_64	9,482,236	+0

Base commit: a2d2696
Branch: main

Summary: Pull Request resolved: facebook#36759 On Thursday the 30th, Apple Released Xcode 14.3.0. This Version of Xcode enforce some version checks for which React-Codegen, which supported iOS 11 as minimum supported version, could not be build anymore. This change ensue that React-Codegen is always aligned to the min version supported by React Native. Plus, it moves CircleCI's Xcode to 14.3.0, to keep this problem in Check. While working on this, I figured that, with the monorepo, Ruby tests stopped working because they were in the wrong folder: I moved them in the right one. ## Changelog: [iOS][Fixed] - Make React Native build with Xcode 14.3.0 and fix tests Differential Revision: D44605617 fbshipit-source-id: e634c70607767ef9a2af08848bce9407b66a3431

facebook-github-bot · 2023-04-01T13:50:05Z

This pull request was exported from Phabricator. Differential Revision: D44605617

oferRounds · 2023-04-01T15:41:37Z

packages/react-native/scripts/cocoapods/__tests__/codegen_utils-test.rb

@@ -527,7 +535,7 @@ def get_podspec_no_fabric_no_script
          'source' => { :git => '' },
          'header_mappings_dir' => './',
          'platforms' => {
-            'ios' => '11.0',
+            'ios' => '12.4',


shouldn’t it be also min_ios_version_supported?

it depends on the philosophy you adopt to write tests.
If you use min_ios_version_supported here, once we move the function to the proper file and we reuse the same function of production, this test would be tautological, as changing what the function in prod returns will also change what returned here.

Personally, I prefer to see my test failing if I bump a version in production code, so I can double check that the change was done on purpose and not by mistake. That's why I hardcoded the value.

Does it make sense?

interesting – makes sense!

LukeIKG · 2023-04-01T19:30:17Z

hey I'm new to developing. my react native project stopped working because of the xcode update. so my question is where do i look for updates? do i need to wait for an xcode update? Cocoapods update? I don't really understand what's happening.

Thanks for your help!

Jonatthu · 2023-04-01T19:32:59Z

@LukeIKG you need to wait until this gets merged or apply the changes manually with patch or downgrade your Xcode to 14.2

LukeIKG · 2023-04-01T19:58:19Z

@LukeIKG you need to wait until this gets merged or apply the changes manually with patch or downgrade your Xcode to 14.2

Thanks for the quick response!
This means I'll wait for a new release and then update my package.json (at "react-native": "0.71.4",) and run npm install -> pod install?

cipolleschi · 2023-04-01T20:57:19Z

So, the root cause is that one of our pods (React-Codegen) is supporting iOS 11, which does not build with Xcode 14.3.

This change bumps the above mentioned pod, fixing the problem.

When the patch is out, yes, you'll have to bump RN in the package.json, apply the changes suggested here and then yarn && cd ios && bundle exec pod install - we suggest to use Ruby Bundler to install your dependencies as it makes sure to use the right version of Cocoapods. If you never used it before, the first time you need to run also bundle install inside the iOS folder. You need to run bundle install only once per project

Meanwhile, you can use the "patch" suggested here

Or, I think, use Xcode 14.2 toolchain with Xcode 14.3, or downgrade Xcode to 14.2.

LukeIKG · 2023-04-02T06:05:17Z

So, the root cause is that one of our pods (React-Codegen) is supporting iOS 11, which does not build with Xcode 14.3.

This change bumps the above mentioned pod, fixing the problem.

When the patch is out, yes, you'll have to bump RN in the package.json, apply the changes suggested here and then yarn && cd ios && bundle exec pod install - we suggest to use Ruby Bundler to install your dependencies as it makes sure to use the right version of Cocoapods. If you never used it before, the first time you need to run also bundle install inside the iOS folder. You need to run bundle install only once per project

Meanwhile, you can use the "patch" suggested here

Or, I think, use Xcode 14.2 toolchain with Xcode 14.3, or downgrade Xcode to 14.2.

Got it to work, yay!
Thanks a lot for clarifying the procedure - really helpful

Summary: Pull Request resolved: facebook#36759 On Thursday the 30th, Apple Released Xcode 14.3.0. This Version of Xcode enforce some version checks for which React-Codegen, which supported iOS 11 as minimum supported version, could not be build anymore. This change ensue that React-Codegen is always aligned to the min version supported by React Native. Plus, it moves CircleCI's Xcode to 14.3.0, to keep this problem in Check. While working on this, I figured that, with the monorepo, Ruby tests stopped working because they were in the wrong folder: I moved them in the right one. ## Changelog: [iOS][Fixed] - Make React Native build with Xcode 14.3.0 and fix tests Reviewed By: blakef Differential Revision: D44605617 fbshipit-source-id: 182bad20fff2bc19f900000560152369013bb481

facebook-github-bot · 2023-04-02T09:20:08Z

This pull request was exported from Phabricator. Differential Revision: D44605617

facebook-github-bot · 2023-04-02T10:36:41Z

This pull request has been merged in cb88e75.

Jackyeoh · 2023-04-03T06:04:23Z

So, the root cause is that one of our pods (React-Codegen) is supporting iOS 11, which does not build with Xcode 14.3.

This change bumps the above mentioned pod, fixing the problem.

When the patch is out, yes, you'll have to bump RN in the package.json, apply the changes suggested here and then yarn && cd ios && bundle exec pod install - we suggest to use Ruby Bundler to install your dependencies as it makes sure to use the right version of Cocoapods. If you never used it before, the first time you need to run also bundle install inside the iOS folder. You need to run bundle install only once per project

Meanwhile, you can use the "patch" suggested here

Or, I think, use Xcode 14.2 toolchain with Xcode 14.3, or downgrade Xcode to 14.2.

For devs working with older versions of react-native (am working with 0.70.6) looking to apply the "patch", looks like we need to define min_ios_version_supported ourselves. The patch then looks like the following:

require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

$min_ios_version_supported = 12.4

platform :ios, $min_ios_version_supported
install! 'cocoapods', :deterministic_uuids => false

# Force pods to match minimum iOS version for React Native
# Fixes build issue on Xcode Cloud where some pods
# Use iOS 12 calls despite being set as iOS 11
def __apply_Xcode_14_3_RC_post_install_workaround(installer)
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      current_target = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET']
      minimum_target = $min_ios_version_supported
      if current_target.to_f < minimum_target.to_f
        config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = minimum_target
      end
    end
  end
end

Summary: Pull Request resolved: #36759 On Thursday the 30th, Apple Released Xcode 14.3.0. This Version of Xcode enforce some version checks for which React-Codegen, which supported iOS 11 as minimum supported version, could not be build anymore. This change ensue that React-Codegen is always aligned to the min version supported by React Native. Plus, it moves CircleCI's Xcode to 14.3.0, to keep this problem in Check. While working on this, I figured that, with the monorepo, Ruby tests stopped working because they were in the wrong folder: I moved them in the right one. ## Changelog: [iOS][Fixed] - Make React Native build with Xcode 14.3.0 and fix tests Reviewed By: blakef Differential Revision: D44605617 fbshipit-source-id: 3ec1f5b36858ef07d9f713d74eb411a1edcccd45

guilepaul · 2023-04-03T18:25:40Z

Just change min_ios_version_supported in Xcode for 12.4

flochtililoch · 2023-04-04T23:45:28Z

I'm a little confused with this statement:

the root cause is that one of our pods (React-Codegen) is supporting iOS 11, which does not build with Xcode 14.3

Xcode 14.3 can build for iOS 11, so I assume that there's some code in React-Codegen that does not play nice with Xcode 14.3 and that it somewhat relates to iOS 11 support.

@cipolleschi could you provide more clarity on what is causing the build issues?

I'm currently running an older RN version (0.67.4), which does have a minimum iOS target version of 11. I'd like to know if bumping it to 12.4 is the only viable solution right now to be able to build with Xcode 14.3

Summary: Pull Request resolved: facebook#36759 On Thursday the 30th, Apple Released Xcode 14.3.0. This Version of Xcode enforce some version checks for which React-Codegen, which supported iOS 11 as minimum supported version, could not be build anymore. This change ensue that React-Codegen is always aligned to the min version supported by React Native. Plus, it moves CircleCI's Xcode to 14.3.0, to keep this problem in Check. While working on this, I figured that, with the monorepo, Ruby tests stopped working because they were in the wrong folder: I moved them in the right one. ## Changelog: [iOS][Fixed] - Make React Native build with Xcode 14.3.0 and fix tests Reviewed By: blakef Differential Revision: D44605617 fbshipit-source-id: 3ec1f5b36858ef07d9f713d74eb411a1edcccd45

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 1, 2023

react-native-bot added Bug Platform: iOS iOS applications. labels Apr 1, 2023

cipolleschi mentioned this pull request Apr 1, 2023

[FIXED in 0.71.6, 0.70.8, 0.69.9] Xcode 14.3 (14E222b) Build Failed with React Native 0.71.5 #36739

Closed

cipolleschi force-pushed the export-D44605617 branch from f0b4b7b to b731d33 Compare April 1, 2023 13:50

oferRounds reviewed Apr 1, 2023

View reviewed changes

cipolleschi force-pushed the export-D44605617 branch from b731d33 to ef27760 Compare April 2, 2023 09:20

facebook-github-bot closed this in cb88e75 Apr 2, 2023

facebook-github-bot added the Merged This PR has been merged. label Apr 2, 2023

hirbod mentioned this pull request Apr 2, 2023

fix: XCode 14.3 temp issues with config plugin showtime-xyz/showtime-frontend#2005

Merged

This was referenced Apr 3, 2023

fix(xcode): backport Xcode 14.3 fix to 69 #36767

Merged

fix(xcode): backport Xcode 14.3 fix to 70 #36768

Merged

fix(xcode): backport Xcode 14.3 fix to 71 #36769

Merged

cipolleschi mentioned this pull request Apr 3, 2023

'value' is unavailable: introduced in iOS 12.0 #36770

Closed

kelset mentioned this pull request Apr 3, 2023

'value' is unavailable: introduced in iOS 12.0 #34106

Closed

This comment was marked as abuse.

Sign in to view

AbreezaSaleem mentioned this pull request Apr 5, 2023

Android working fine but iOS returns an error regarding React-Codegen from project Pods #34651

Closed

iujames mentioned this pull request Apr 13, 2023

Update CircleCI to use Xcode 14.3 appcues/appcues-react-native-module#79

Merged

wmathurin mentioned this pull request Jun 15, 2023

Bump iOS deployment target to 15.0 forcedotcom/SalesforceMobileSDK-Templates#361

Merged

Kudo mentioned this pull request Aug 1, 2023

The "Run fastlane" step failed with an unknown error expo/expo#23777

Closed

This was referenced Aug 10, 2023

[LOCAL] Fix Ruby Tests for 0.72 #38919

Closed

[LOCAL] Add script poll maven #38980

Merged

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39575

Merged

cipolleschi mentioned this pull request Oct 12, 2023

[Local] Fix CI for 0.72, with Acitve Support and Xcode15 #40855

Merged

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.72) #41276

Merged

stevenpetryk mentioned this pull request Nov 28, 2023

Avoid using Xcode 15's gcc when compiling glog discord/react-native#48

Merged

cipolleschi mentioned this pull request Dec 27, 2023

[RN][iOS] Improve Swift support for 3rd party libs #42075

Merged

This was referenced Feb 28, 2024

[RN][IOS] Fix flags for new arch #43240

Merged

[RN][iOS]Rename BUILD_FROM_SOURCE to RCT_BUILD_HERMES_FROM_SOURCE #43247

Merged

[RN][iOS][0.72] Fix flipper for Xcode 15.3 #43344

Merged

cipolleschi mentioned this pull request Jun 28, 2024

[CI] Move machines to M1 for 0.72 #45215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Cocoapods for Xcode 14.3.0 #36759

Fix Cocoapods for Xcode 14.3.0 #36759

cipolleschi commented Apr 1, 2023

facebook-github-bot commented Apr 1, 2023

analysis-bot commented Apr 1, 2023

facebook-github-bot commented Apr 1, 2023

oferRounds Apr 1, 2023

cipolleschi Apr 1, 2023

oferRounds Apr 1, 2023

LukeIKG commented Apr 1, 2023

Jonatthu commented Apr 1, 2023

LukeIKG commented Apr 1, 2023

cipolleschi commented Apr 1, 2023

LukeIKG commented Apr 2, 2023

facebook-github-bot commented Apr 2, 2023

facebook-github-bot commented Apr 2, 2023

Jackyeoh commented Apr 3, 2023

This comment was marked as abuse.

guilepaul commented Apr 3, 2023

flochtililoch commented Apr 4, 2023

Fix Cocoapods for Xcode 14.3.0 #36759

Fix Cocoapods for Xcode 14.3.0 #36759

Conversation

cipolleschi commented Apr 1, 2023

Changelog:

facebook-github-bot commented Apr 1, 2023

analysis-bot commented Apr 1, 2023

facebook-github-bot commented Apr 1, 2023

oferRounds Apr 1, 2023

Choose a reason for hiding this comment

cipolleschi Apr 1, 2023

Choose a reason for hiding this comment

oferRounds Apr 1, 2023

Choose a reason for hiding this comment

LukeIKG commented Apr 1, 2023

Jonatthu commented Apr 1, 2023

LukeIKG commented Apr 1, 2023

cipolleschi commented Apr 1, 2023

LukeIKG commented Apr 2, 2023

facebook-github-bot commented Apr 2, 2023

facebook-github-bot commented Apr 2, 2023

Jackyeoh commented Apr 3, 2023

This comment was marked as abuse.

guilepaul commented Apr 3, 2023

flochtililoch commented Apr 4, 2023