Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS][0.72] Fix flipper for Xcode 15.3 #43344

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Mar 6, 2024

Summary

Following #43335, we implemented the fix suggested here.

The rationale of applying this fix rather then releasing a new version of Flipper is because we will have to release Flipper 0.248.0, and the latest flipper version on Cocoapods is 0.233.0 (15 versions behind).

Plus, we have to port the fix to 0.73 and 0.71 and bumping Flipper there would be a major pain and it might require more time and introduce other bugs we don't want.

Changelog

[iOS][Fixed] - Make 0.72 build with Xcode 15.3

Test Plan

Tested locally + CircleCI is green

@cipolleschi cipolleschi changed the base branch from main to 0.72-stable March 6, 2024 14:02
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 6, 2024
@cipolleschi cipolleschi marked this pull request as ready for review March 6, 2024 14:03
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-flipper-072 branch 2 times, most recently from afcfb08 to 7feff1d Compare March 6, 2024 14:30
@analysis-bot
Copy link

analysis-bot commented Mar 6, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,492,847 -9,511,508
android hermes armeabi-v7a 7810754 n/a
android hermes x86 8962934 n/a
android hermes x86_64 8824181 n/a
android jsc arm64-v8a 9,151,784 -12,211,018
android jsc armeabi-v7a 8341411 n/a
android jsc x86 9205069 n/a
android jsc x86_64 9463742 n/a

Base commit: 3ed0ff3
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-flipper-072 branch from 7feff1d to f5f11e7 Compare March 6, 2024 15:32
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-flipper-072 branch 2 times, most recently from 8212c73 to 0f37f20 Compare March 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants