This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix: XCode 14.3 temp issues with config plugin #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirbod
requested review from
intergalacticspacehighway and
alantoa
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Preview - StorybookThis pull request preview deployment is now available. Open Details✅ Preview: exp+io.showtime.storybook://expo-development-client/?url=https://u.expo.dev/e77d5b68-bb27-45da-aa5c-96c1fdbf6706&channel-name=pr-2005 Comment ID: |
PR Preview - AppThis pull request preview deployment is now available. Open Details✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-2005 Comment ID: |
|
hi there! hope react native will release a new patch version with the fix this week and we will update with a new |
intergalacticspacehighway
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Our App can't compile with the new XCode 14.3 currently.
How
Looks like there are packages which haven't updated their podspecs to target the correct deployment target. Added a Config plugin to fix this issue for now, since build properties alone are not enough to fix this.
Credit goes to: facebook/react-native#34106 (comment)
The upstream bugfix is already merged but I don't know if this is going to be backported, so we need to monitor new releases.
facebook/react-native#36759
Test Plan