Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement IERC7802 #12790

Merged

Conversation

agusduha
Copy link
Contributor

@agusduha agusduha commented Nov 1, 2024

Description

  • Rename ICrosschainERC20 to IERC7802
  • Add support to ERC165
  • Integrate SuperchainTokenBridge with ERC165

Tests

Adjust SuperchainERC20, SuperchainWETH and SuperchainTokenBridge tests

Additional context

This PR implements the standard proposed in ethereum/ERCs#692

Metadata

Closes #12789

* feat: add IERC7802

* fix: token address fuzz error

* feat: remove ERC165 contract inheritance
@blmalone blmalone self-requested a review November 1, 2024 20:25
Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass done, I'll look more closely at this soon 👍🏻

@blmalone
Copy link
Contributor

blmalone commented Nov 1, 2024

/ci authorize 9fd55c6

@gotzenx gotzenx requested review from maurelian and blmalone November 1, 2024 22:38
@blmalone
Copy link
Contributor

blmalone commented Nov 3, 2024

/ci authorize 9fd55c6

1 similar comment
@blmalone
Copy link
Contributor

blmalone commented Nov 4, 2024

/ci authorize 9fd55c6

* feat: add IERC20 interface support

* fix: interfaces tests
@blmalone
Copy link
Contributor

blmalone commented Nov 4, 2024

/ci authorize 98f0c1e

Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blmalone blmalone enabled auto-merge November 4, 2024 20:26
@blmalone blmalone disabled auto-merge November 4, 2024 20:26
@blmalone blmalone added this pull request to the merge queue Nov 4, 2024
Merged via the queue into ethereum-optimism:develop with commit 94ab846 Nov 4, 2024
49 checks passed
GrapeBaBa pushed a commit to optimism-java/optimism that referenced this pull request Nov 13, 2024
* feat: add IERC7802 (ethereum-optimism#123)

* feat: add IERC7802

* fix: token address fuzz error

* feat: remove ERC165 contract inheritance

* feat: add IERC20 interface support (ethereum-optimism#124)

* feat: add IERC20 interface support

* fix: interfaces tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new ERC-7802
3 participants