Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add IERC20 interface support #124

Merged
merged 2 commits into from
Nov 4, 2024
Merged

feat: add IERC20 interface support #124

merged 2 commits into from
Nov 4, 2024

Conversation

agusduha
Copy link
Member

@agusduha agusduha commented Nov 4, 2024

No description provided.

@agusduha agusduha self-assigned this Nov 4, 2024
0xDiscotech
0xDiscotech reviewed Nov 4, 2024
View reviewed changes
Copy link

@0xDiscotech 0xDiscotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing supports interface of type ERC20 on tests, then looking good 👍

@agusduha agusduha merged commit 98f0c1e into sc-feat/add-ierc7802 Nov 4, 2024
1 check passed
@agusduha agusduha deleted the feat/add-ierc20-interface-support branch November 4, 2024 19:19
agusduha added a commit that referenced this pull request Nov 5, 2024
@agusduha
feat: implement IERC7802 (ethereum-optimism#12790)
94ab846 
* feat: add IERC7802 (#123)

* feat: add IERC7802

* fix: token address fuzz error

* feat: remove ERC165 contract inheritance

* feat: add IERC20 interface support (#124)

* feat: add IERC20 interface support

* fix: interfaces tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDiscotech 0xDiscotech 0xDiscotech approved these changes

@0xParticle 0xParticle 0xParticle approved these changes

@gotzenx gotzenx Awaiting requested review from gotzenx

Assignees

@agusduha agusduha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agusduha @0xParticle @0xDiscotech