Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Crosschain Token Interface #692

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

0xParticle
Copy link

This ERC introduces a minimal interface for tokens to communicate cross-chain. It allows bridges with mint and burn rights to send and relay token transfers with a standardized API.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 30, 2024

File ERCS/erc-7802.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@github-actions github-actions bot added the w-ci label Oct 30, 2024
@github-actions github-actions bot removed the w-ci label Oct 30, 2024
@github-actions github-actions bot removed the w-ci label Oct 30, 2024
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
ERCS/erc-0000.md Outdated Show resolved Hide resolved
Copy link

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested amendments.

@0xParticle
Copy link
Author

0xParticle commented Nov 8, 2024

Nothing about any of these interfaces is "crosschain" in nature so wondering why not just use an existing "mintable" or "burnable" interface? What about the existing xERC20 standard is insufficient?

wondering why not just use an existing "mintable" or "burnable" interface
Token issuers might want to implement different logic when minting and burning come from a bridge, such as additional security checks or events. Even though it is possible to use a standard mintable interface, having a separate function allows for a clear separation of concerns.

It might feel unnatural for tokens that do not implement any logic different from a regular mint and burn, but we want to ensure the standardized API works for the general case.

What about the existing https://github.com/ethereum/ERCs/pull/89 is insufficient?
xERC20 is not insufficient. In fact, adding mint/burn limits is a great security feature and can be built very easily on top of this ERC. Our proposal aims to complement standards like xERC20 by providing a minimalistic interface that includes only the common essential actions across various cross-chain token standards.

Features such as mint and burn limits should be optional rather than mandatory components of a cross-chain token interface. It is possible to set the limits to max in xERC20, but you would still need a token owner, which might not be the most general design.

Again, our proposed standard is not intended to compete with xERC20 in any way. It's a smaller Lego piece that xERC20 and other standards can use.

@0xParticle
Copy link
Author

0xParticle commented Nov 8, 2024

Nothing about any of these interfaces is "crosschain" in nature so wondering why not just use an existing "mintable" or "burnable" interface? What about the existing xERC20 standard is insufficient?

or compatibility to the existing xERC20 for that matter

See #692 (comment)

@0xParticle
Copy link
Author

This interface should be made to match xERC20, which is essentially an implementation of this, but with safety features such as rate limiting. When it is very easy for this standard to match that one, why doesn't it?

Yes, we could make it match with xERC20. The only difference between the two lies in function naming. In our proposal, we use distinct function names—crosschainMint and crosschainBurn—to explicitly differentiate minting and burning actions triggered by a bridge from standard token operations. We believe that having separate function names for cross-chain interactions provides clearer semantics and allows token contracts to implement specific logic or security measures for these operations.

We are open to collaborating on unifying the naming conventions, whether that involves adjusting names in our proposal or in xERC20.

@yorhodes
Copy link

yorhodes commented Nov 8, 2024

Features such as mint and burn limits should be optional rather than mandatory components of a cross-chain token interface. It is possible to set the limits to max in xERC20, but you would still need a token owner, which might not be the most general design.

Again, our proposed standard is not intended to compete with xERC20 in any way. It's a smaller Lego piece that xERC20 and other standards can use.

Thanks for clarifying @0xParticle. I do think it would be in the spirit of the ERC process to mitigate fragmentation by reusing the xERC20 function interface (subset). This seems much more natural than encouraging existing tokens to upgrade/migrate to this new interface.

I understand that you think the crosschain prefix is important to be explicit about. My personal feeling is the opposite -- that there is no reason the token standard needs to distinguish between "crosschain" and "local" mint/burn roles, similar to how it is an antipattern to distinguish between EOAs and contracts. Token contracts can still implement crosschain checks/logic behind the mint/burn functions if they so choose.

Copy link

@WojasKrk WojasKrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xxx

@zainbacchus
Copy link

zainbacchus commented Nov 13, 2024

I do think it would be in the spirit of the ERC process to mitigate fragmentation by reusing the xERC20 function interface (subset). This seems much more natural than encouraging existing tokens to upgrade/migrate to this new interface.

Definitely understand the spirit of reusing where possible, one concern in reusing mint/burn is with generating a false sense of interoperability for tokens that are already deployed and have no way to deploying to the same address on other chains which I imagine will be important to mitigate the issue that authorized bridges will need to know what address does each token have in each chain - which I don't believe the xERC20 draft EIP has a formal requirement for currently.

@0xParticle
Copy link
Author

0xParticle commented Nov 13, 2024

Thanks for clarifying @0xParticle. I do think it would be in the spirit of the ERC process to mitigate fragmentation by reusing the xERC20 function interface (subset). This seems much more natural than encouraging existing tokens to upgrade/migrate to this new interface.

I understand that you think the crosschain prefix is important to be explicit about. My personal feeling is the opposite -- that there is no reason the token standard needs to distinguish between "crosschain" and "local" mint/burn roles, similar to how it is an antipattern to distinguish between EOAs and contracts. Token contracts can still implement crosschain checks/logic behind the mint/burn functions if they so choose.

Thank you for your feedback! This has been the main concern so far, so I'll elaborate on why we think having separate functions makes a lot of sense.

Local minting and burning are fundamentally different from cross-chain minting and burning.

  • In cross-chain operations, the total circulating supply across all chains is expected to remain constant, as tokens are transferred between chains rather than created or destroyed in isolation.
  • Agents that mint and burn tokens in cross-chain transfer fundamentally differ from token owners. It make sense for the two actors to have different permissions.

Therefore, having different checks, access controls, and logic for cross-chain actions is reasonable. The mint/burn limits that xERC20 introduces are a great example. Merging local and cross-chain minting/burning into the same functions can lead to complex implementations that intertwine different operational logic. By splitting into two, we separate concerns, making the codebase cleaner and more maintainable.

This separation of concerns is particularly relevant for

  • Upgrades: Any changes in access control, limits, or logic will only affect the separate cross-chain functions (crosschainMint and crosschainBurn) without altering the standard local mint and burn implementations.
  • Integrations with Different Chains: To make an ERC20 token cross-chain compatible, you simply need to implement the ERC-7802 extension with the corresponding access controls for each chain. For example, when integrating with Optimism, the ERC20 token would grant access to the Optimism bridge; when integrating with Arbitrum, it would grant access to the Arbitrum bridge. The local mint and burn functions remain unchanged. Using dedicated functions for cross-chain operations provides a more modular approach, avoiding the need to modify the base implementation for each chain.

A similar reasoning applies to having dedicated cross-chain-specific events. The separation significantly facilitates the work of indexers, analytics tools, and auditors. It allows for straightforward tracking of cross-chain activities, detecting anomalies, and monitoring bridge operations. If cross-chain and local events are indistinguishable, off-chain agents must implement complex logic to differentiate them, increasing the potential for errors and inefficiencies.

The analogy between distinguishing EOAs/contracts and local/cross-chain operations isn't directly applicable. As reflected in the protocol's roadmap, the Ethereum community is working towards account abstraction to unify EOAs and contract accounts. However, there's no equivalent movement to unify local and cross-chain token operations. Cross-chain actions inherently involve additional complexities and external dependencies that justify distinct handling in token contracts.

Finally, the standard is still compatible with xERC20 via custom adapters, even with a different naming. We will work to improve this compatibility, as we think xERC20 is a great standard and want to support it. As a matter of fact, my folks at Wonderland are coauthors to the xERC20 standard.

@jacekv
Copy link

jacekv commented Nov 14, 2024

This looks very much like the Pantos token contract for native cross-chain tokens. Just the naming of the functions is different, yet concept is the same:
https://github.com/pantos-io/ethereum-contracts/blob/main/src/interfaces/IPantosToken.sol

@github-actions github-actions bot added the w-ci label Nov 19, 2024
@0xParticle
Copy link
Author

Regarding compatibility with xERC20 (ERC-7802), I wrote this document:
https://defi-wonderland.notion.site/xERC20-ERC7802-compatibility-14c9a4c092c780ca94a8cb81e980d813?pvs=4

event CrosschainMint(address indexed _to, uint256 _amount, address indexed _sender);
```

Note: implementations might consider additionally emitting `Transfer(address(0), _to, _amount)` to be compliant with [ERC-5679](./eip-5679.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suggest making the Transfer events mandatory.

ERC-20 is more relevant than ERC-5679 IMO, and in the former it's already specified as SHOULD (i.e., a strong recommendation):

A token contract which creates new tokens SHOULD trigger a Transfer event with the _from address set to 0x0 when tokens are created.

@SamWilsn
Copy link
Contributor

Gentle reminder to keep technical discussion in the Ethereum Magicians thread. It's easy to lose context after the pull request is merged.

ERCS/erc-7802.md Outdated
---
eip: 7802
title: Crosschain Token Interface
description: Minimal token interface for cross-chain transfers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal

Too many standards claim to be minimal. I'd recommend removing this, and using your description to further elaborate on the ideas introduced in your title.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified this section, let me know your thoughts now

ERCS/erc-7802.md Outdated

## Abstract

This standard introduces a minimal interface for tokens to communicate cross-chain. It allows bridges with mint and burn rights to send and relay token transfers with a standardized API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad, but I'd like to see a bit more technical meat here. Could you sketch out how your proposal operates, in addition to the description you already have.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more technical details.

ERCS/erc-7802.md Outdated Show resolved Hide resolved

**`CrosschainMint`**

MUST trigger when `crosschainMint` is successfully called.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaves a lot unspecified (which is fine if it's intentional.) For example, should other non-standard functions that also effectively perform a crosschain mint also trigger this event, or is it specifically tied to this function?

ERCS/erc-7802.md Outdated Show resolved Hide resolved
ERCS/erc-7802.md Show resolved Hide resolved
As discussed in the Motivation section, a minimal, flexible cross-chain standard interface is necessary. The problem becomes larger as more tokens are deployed without a standardized format.

- Upgradable tokens can be upgraded to implement the new interface.
- Non-upgradable tokens cannot implement the interface on the token itself. They can still migrate to a standard-compliant version using a lockbox mechanism, as proposed by xERC-20. The idea is to lock non-mintable tokens and mint the same amount of interface-compliant tokens. The bridge contract can act as a lockbox on the native chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does xERC-20 have an ERC? If so, you should link it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has an open PR to the ERC repo with assigned number 7281, but it has not been merged. If I mention the ERC-7281 in this ERC, the EIP validator asks for an internal link, which I can't reference at the moment.

ERCS/erc-7802.md Outdated Show resolved Hide resolved
ERCS/erc-7802.md Outdated Show resolved Hide resolved
Copy link

@Saraeutsza Saraeutsza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defi-wonderland:erc/crosschain-token-interface

Copy link

The commit 5d26ebb (as a parent of d3b7d38) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Dec 17, 2024
@github-actions github-actions bot removed the w-ci label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.