-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21099] X-Types examples #4924
[21099] X-Types examples #4924
Conversation
03d49e8
to
a90f5d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very meaningful example ! Leaving two NITs and a suggestion.
It seems that ShapesDemo Types should be regenerated in order to get Ubuntu CI
running again
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Description
This PR adds an X-Types example in which a type is defined in run-time at the publisher side using the Dynamic Types API, and the subscriber discovers the type, creates a reader for it, and prints the received data.
This example is type compatible with the
hello_world
one (a compatibility test has been added for this).This PR depends on:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist