-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeObjectRegistry refactor [21132] #4874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
force-pushed
the
feature/type-registry-refactor
branch
from
May 30, 2024 08:04
83e3470
to
87bd8a4
Compare
richiware
force-pushed
the
feature/type-registry-refactor
branch
from
May 30, 2024 13:27
01e31e5
to
ef57049
Compare
5 tasks
richiware
changed the title
TypeObjectRegistry refactor
TypeObjectRegistry refactor [21132]
Jun 3, 2024
This was referenced Jun 3, 2024
richiware
force-pushed
the
feature/type-registry-refactor
branch
from
June 5, 2024 10:34
5a86d71
to
bc34343
Compare
richiware
force-pushed
the
feature/type-registry-refactor
branch
from
June 5, 2024 12:08
bc34343
to
2cba6d6
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
force-pushed
the
feature/type-registry-refactor
branch
from
June 13, 2024 12:40
0dabcec
to
56b31e2
Compare
adriancampo
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@richiprosima please test_3 discovery-server |
1 similar comment
@richiprosima please test_3 discovery-server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this refactor, any registration in
TypeObjectRegistry
will return aTypeIdentifierPair
which aTopicDataType
can use to configure internally DDS.Next PRs depends on this one:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist