update palantirJavaFormat for Java 21

[slachiewicz]

Based on @basil user report and fix #1774

[nedtwigg]

Looks like issues around gradle variants.

 project : > com.palantir.javaformat:palantir-java-format:2.38.0 > com.palantir.javaformat:palantir-java-format-spi:2.38.0

  Caused by: org.gradle.internal.component.AmbiguousConfigurationSelectionException: The consumer was configured to find attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external'. However we cannot choose between the following variants of com.google.guava:guava:32.1.2-jre:
    - androidRuntimeElements
    - jreRuntimeElements
  All of them match the consumer attributes:
    - Variant 'androidRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'android' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
    - Variant 'jreRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'standard-jvm' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
      at app//com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)

We had similar issues in #1808

[nedtwigg]

FYI, main is now on Gradle 8.4, so if you want to bring Java 21 back into the test matrix, that would be welcome. I don't think it will help with the variant issue above though...

[slachiewicz]

Unfortunately, it's still the same error with the new Gradle - no idea how to fix this dependency issue.

[nedtwigg]

Anyone know why this PR isn't running CI? It's doing spotlessCheck assemble testClasses but none of the actual testrunner runs...

[nedtwigg]

  org.gradle.api.artifacts.ResolveException: Could not resolve all dependencies for [com.palantir.javaformat:palantir-java-format:2.38.0].
      at com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)
  Caused by: org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':detachedConfiguration1'.
      at app//com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)
  Caused by: org.gradle.internal.resolve.ModuleVersionResolveException: Could not resolve com.google.guava:guava:32.1.2-jre.
  Required by:
      project : > com.palantir.javaformat:palantir-java-format:2.38.0
      project : > com.palantir.javaformat:palantir-java-format:2.38.0 > com.palantir.javaformat:palantir-java-format-spi:2.38.0

  Caused by: org.gradle.internal.component.AmbiguousConfigurationSelectionException: The consumer was configured to find attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external'. However we cannot choose between the following variants of com.google.guava:guava:32.1.2-jre:
    - androidRuntimeElements
    - jreRuntimeElements
  All of them match the consumer attributes:
    - Variant 'androidRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'android' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
    - Variant 'jreRuntimeElements' capabilities com.google.collections:google-collections:32.1.2-jre and com.google.guava:guava:32.1.2-jre declares attribute 'org.gradle.category' with value 'library', attribute 'org.gradle.dependency.bundling' with value 'external':
        - Unmatched attributes:
            - Provides org.gradle.jvm.environment 'standard-jvm' but the consumer didn't ask for it
            - Provides org.gradle.jvm.version '8' but the consumer didn't ask for it
            - Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
            - Provides org.gradle.status 'release' but the consumer didn't ask for it
            - Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
      at app//com.diffplug.spotless.java.PalantirJavaFormatStepTest.jvm13Features(PalantirJavaFormatStepTest.java:35)

[Goooler]

@slachiewicz Seems I've fixed the dependency resolving issue, you can ref Goooler#12. And if you wanna run CI on Java 21, still need to fix GJF tests. You may just add .add(21, "2.38.0") but 073a762.

[StefanLobbenmeierObjego]

FYI with gradle 8.5 being released today this became more urgent as it blocks users from running gradle on java 21

I could confirm that manually setting the version works for me though (as also shown in this comment: palantir/palantir-java-format#943 (comment))

[Goooler]

I was planning to fix Java 21 compatibility issues for Gradle, we can probably fix Maven first.

[steven-sheehy]

@Goooler Is it possible to submit your changes as a separate PR if it's passing CI since this one doesn't seem to see any updates?

[Goooler]

It's in #1920.

[nedtwigg]

• Going to be merged soon via Fix Java 21 compatibilities #1920

[nedtwigg]

Published in plugin-gradle 6.23.3 and plugin-maven 2.41.1.