Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 21 #7294

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Upgrade to Java 21 #7294

merged 3 commits into from
Dec 6, 2023

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Nov 30, 2023

Description:

  • Bump Java version from 17 to 21
  • Change @Retryable to not use deprecated value attribute
  • Fix compiler warnings
  • Remove unused Query DSL dependency
  • Suppress compiler warnings due to plugin generated code

Related issue(s):

Fixes #7233

Notes for reviewer:

Requires IntelliJ IDEA 2023.3 and Java 21 installed locally. Recommended to use sdkman sdk install java 21-tem.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added the enhancement Type: New feature label Nov 30, 2023
@steven-sheehy steven-sheehy self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9e04bc) 92.50% compared to head (c119b0a) 92.50%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7294      +/-   ##
============================================
- Coverage     92.50%   92.50%   -0.01%     
  Complexity     6828     6828              
============================================
  Files           867      867              
  Lines         28490    28407      -83     
  Branches       3309     3307       -2     
============================================
- Hits          26355    26277      -78     
+ Misses         1372     1368       -4     
+ Partials        763      762       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: Steven Sheehy <[email protected]>
@steven-sheehy steven-sheehy added this to the 0.95.0 milestone Dec 6, 2023
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@steven-sheehy steven-sheehy marked this pull request as ready for review December 6, 2023 18:00
@steven-sheehy steven-sheehy requested a review from a team December 6, 2023 18:00
Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@steven-sheehy steven-sheehy merged commit 6e27167 into main Dec 6, 2023
30 checks passed
@steven-sheehy steven-sheehy deleted the 7233-java-21 branch December 6, 2023 19:25
IvanKavaldzhiev pushed a commit that referenced this pull request Dec 13, 2023
* Bump Java version from 17 to 21
* Change `@Retryable` to not use deprecated `value` attribute
* Fix compiler warnings
* Remove unused Query DSL dependency
* Suppress compiler warnings due to plugin generated code

---------

Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
IvanKavaldzhiev pushed a commit that referenced this pull request Jan 8, 2024
* Bump Java version from 17 to 21
* Change `@Retryable` to not use deprecated `value` attribute
* Fix compiler warnings
* Remove unused Query DSL dependency
* Suppress compiler warnings due to plugin generated code

---------

Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
IvanKavaldzhiev pushed a commit that referenced this pull request Jan 8, 2024
* Bump Java version from 17 to 21
* Change `@Retryable` to not use deprecated `value` attribute
* Fix compiler warnings
* Remove unused Query DSL dependency
* Suppress compiler warnings due to plugin generated code

---------

Signed-off-by: Steven Sheehy <[email protected]>
Signed-off-by: IvanKavaldzhiev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Java 21
3 participants