Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) #135

Merged
merged 3 commits into from
Oct 2, 2023
Merged

[MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) #135

merged 3 commits into from
Oct 2, 2023

Conversation

tisonkun
Copy link
Member

slawekjaranowski
slawekjaranowski reviewed Sep 23, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
slawekjaranowski
slawekjaranowski reviewed Sep 23, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member

I would like to wait for fix in spotless: diffplug/spotless#1822

If no before next release of parents we can consider it

@gnodet gnodet mentioned this pull request Sep 26, 2023
Closed
@slachiewicz slachiewicz changed the title Support develop with JDK 21 [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) Oct 1, 2023
@tisonkun
Copy link
Member Author

tisonkun commented Oct 2, 2023

Thanks for your review and suggestion!

We can still use this patch now as diffplug/spotless#1822 is unresolved yet.

@slachiewicz
Copy link
Member

Yes, I think patching spotless may take some more time.

@slachiewicz slachiewicz merged commit b2271de into apache:master Oct 2, 2023
7 checks passed
@slachiewicz slachiewicz added the bug label Oct 2, 2023
@tisonkun tisonkun deleted the patch-1 branch October 2, 2023 12:29
@tisonkun
Copy link
Member Author

tisonkun commented Oct 2, 2023 •
edited
Loading

May I ask the release plan including this patch? I create this patch due to my project (hawkeye) want to upgrade to be compatible with JDK 21 dev :D

@slawekjaranowski
Copy link
Member

@tisonkun - Just out of curiosity - how this project impact on your project?
It is only used by Apache Maven projects as our parents.

@tisonkun
Copy link
Member Author

tisonkun commented Oct 2, 2023

Oops. It's not hawkeye where I can pin dependencies by myself and doesn't inherit the MPOM...

I forget where I come from now 🤣

@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2023

@slawekjaranowski I encountered it again and remembered. I met this issue from Apache Curator who inherited this pom.

@slawekjaranowski slawekjaranowski mentioned this pull request Oct 11, 2023
Merged
@gnodet gnodet added this to the MAVEN-41 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
MAVEN-41
Development

Successfully merging this pull request may close these issues.
4 participants
@tisonkun @slawekjaranowski @slachiewicz @gnodet