Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty message with media implementation #113

Merged
merged 9 commits into from
Mar 12, 2020
Merged

Empty message with media implementation #113

merged 9 commits into from
Mar 12, 2020

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Mar 6, 2020 •
edited
Loading

Description

This PR added the possibility to post an empty message with medias without errors.
Closes #110

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@leobragaz leobragaz self-assigned this Mar 6, 2020
@codecov-io
Copy link

codecov-io commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #113   +/-   ##
======================================
  Coverage    82.4%   82.4%           
======================================
  Files          32      32           
  Lines        1478    1478           
======================================
  Hits         1218    1218           
  Misses        231     231           
  Partials       29      29
Impacted Files Coverage Δ
x/posts/internal/types/msgs.go 91.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740ef9c...3bdc621. Read the comment docs.

RiccardoM
RiccardoM reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some things to implement

x/posts/internal/types/msgs.go Outdated Show resolved Hide resolved
x/posts/internal/types/msgs_test.go Outdated Show resolved Hide resolved
cli_test/cli_posts_test.go Show resolved Hide resolved
x/posts/internal/types/msgs.go Show resolved Hide resolved
@leobragaz leobragaz requested a review from RiccardoM March 10, 2020 11:01
RiccardoM
RiccardoM suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Some very small error texts changes required but otherwise good to merge

x/posts/internal/types/msgs.go Outdated Show resolved Hide resolved
x/posts/internal/types/msgs_test.go Outdated Show resolved Hide resolved
x/posts/internal/types/msgs_test.go Outdated Show resolved Hide resolved
x/posts/internal/types/msgs_test.go Outdated Show resolved Hide resolved
x/posts/internal/types/post.go Outdated Show resolved Hide resolved
@leobragaz leobragaz requested a review from RiccardoM March 11, 2020 18:17
RiccardoM
RiccardoM approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiccardoM RiccardoM merged commit ede318f into master Mar 12, 2020
@RiccardoM RiccardoM mentioned this pull request Mar 12, 2020
Closed
@RiccardoM RiccardoM deleted the leonardo/empty-message-with-media-impl branch March 30, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees

@leobragaz leobragaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create an empty-message post with a photo
3 participants
@leobragaz @codecov-io @RiccardoM