You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #113 we've allowed to create posts with an empty message when there are some medias attached to them. This has caused the CLI command in that case to be very unnatural to use.
Of course, with this implementation inside the CLI tx command handler we need to check that the message is not empty when the medias are, and vice-versa, to make sure that at least one between the message and the medias are specified.
The text was updated successfully, but these errors were encountered:
Making the cobra.MinimumArgs to 1. Only <subspace> is mandatory. Keep <message> as an argument but optional. Put --allow-comments as a flag and its default is true if not specified. The command can be like this.
desmoscli tx posts create <subspace> "My message" \
--allow-comments=false
--flags
I feel putting the <message> as an argument in the command line is more straightforward.
Feature description
With #113 we've allowed to create posts with an empty message when there are some medias attached to them. This has caused the CLI command in that case to be very unnatural to use.
Currently the command is
Which results (when an empty message is specified) to be:
This is very unnatural for the users and we should probably fix it.
Implementation proposal
What I suggest to do is improve the posting command by making the message an optional flag instead of a required argument:
Of course, with this implementation inside the CLI tx command handler we need to check that the message is not empty when the medias are, and vice-versa, to make sure that at least one between the message and the medias are specified.
The text was updated successfully, but these errors were encountered: