Allow empty message when media(s) are specified

See PR #113

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Version 0.4.0
 ## Changes
 - Improved `alias.go` files (#103)
+- Added the support for posting empty-message posts with medias (#110)
 
 # Version 0.3.0
 ## Changes

cli_test/cli_posts_test.go

@@ -65,7 +65,68 @@ func TestDesmosCLIPostsCreateNoMediasNoPollData(t *testing.T) {
 	f.Cleanup()
 }
 
-func TestDesmosCLIPostsCreateWithMedias(t *testing.T) {
+func TestDesmosCLIPostsCreateWithMediasAndEmptyMessage(t *testing.T) {
+	t.Parallel()
+	f := InitFixtures(t)
+
+	// Start Desmosd server
+	proc := f.GDStart()
+	defer proc.Stop(false)
+
+	// Save key addresses for later use
+	fooAddr := f.KeyAddress(keyFoo)
+
+	// Later usage variables
+	subspace := "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e"
+	message := ""
+	fooAcc := f.QueryAccount(fooAddr)
+	startTokens := sdk.TokensFromConsensusPower(140)
+	require.Equal(t, startTokens, fooAcc.GetCoins().AmountOf(denom))
+
+	// Create a post
+	success, _, sterr := f.TxPostsCreate(subspace, message, true, fooAddr, "-y",
+		"--media https://example.com/media1,text/plain",
+		"--media https://example.com/media2,application/json")
+	require.True(t, success)
+	require.Empty(t, sterr)
+	tests.WaitForNextNBlocksTM(1, f.Port)
+
+	// Make sure the post is saved
+	storedPosts := f.QueryPosts()
+	require.NotEmpty(t, storedPosts)
+	post := storedPosts[0]
+	require.Equal(t, posts.PostID(1), post.PostID)
+	require.Nil(t, post.PollData)
+	require.Len(t, post.Medias, 2)
+	require.Equal(t, post.Medias, posts.NewPostMedias(
+		posts.NewPostMedia("https://example.com/media1", "text/plain"),
+		posts.NewPostMedia("https://example.com/media2", "application/json")))
+
+	// Test --dry-run
+	success, _, _ = f.TxPostsCreate(subspace, message, true, fooAddr, "--dry-run",
+		"--media https://second.example.com/media1,text/plain",
+		"--media https://second.example.com/media2,application/json")
+	require.True(t, success)
+
+	// Test --generate-only
+	success, stdout, stderr := f.TxPostsCreate(subspace, message, true, fooAddr, "--generate-only",
+		"--media https://third.example.com/media1,text/plain",
+		"--media https://third.example.com/media2,application/json")
+	require.Empty(t, stderr)
+	require.True(t, success)
+	msg := unmarshalStdTx(f.T, stdout)
+	require.NotZero(t, msg.Fee.Gas)
+	require.Len(t, msg.Msgs, 1)
+	require.Len(t, msg.GetSignatures(), 0)
+
+	// Check state didn't change
+	storedPosts = f.QueryPosts()
+	require.Len(t, storedPosts, 1)
+
+	f.Cleanup()
+}
+
+func TestDesmosCLIPostsCreateWithMediasAndNonEmptyMessage(t *testing.T) {
 	t.Parallel()
 	f := InitFixtures(t)
 
@@ -126,6 +187,58 @@ func TestDesmosCLIPostsCreateWithMedias(t *testing.T) {
 	f.Cleanup()
 }
 
+func TestDesmosCLIPostsCreateWithNoMediasAndNonEmptyMessage(t *testing.T) {
+	t.Parallel()
+	f := InitFixtures(t)
+
+	// Start Desmosd server
+	proc := f.GDStart()
+	defer proc.Stop(false)
+
+	// Save key addresses for later use
+	fooAddr := f.KeyAddress(keyFoo)
+
+	// Later usage variables
+	subspace := "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e"
+	message := "message"
+	fooAcc := f.QueryAccount(fooAddr)
+	startTokens := sdk.TokensFromConsensusPower(140)
+	require.Equal(t, startTokens, fooAcc.GetCoins().AmountOf(denom))
+
+	// Create a post
+	success, _, sterr := f.TxPostsCreate(subspace, message, true, fooAddr, "-y")
+	require.True(t, success)
+	require.Empty(t, sterr)
+	tests.WaitForNextNBlocksTM(1, f.Port)
+
+	// Make sure the post is saved
+	storedPosts := f.QueryPosts()
+	require.NotEmpty(t, storedPosts)
+	post := storedPosts[0]
+	require.Equal(t, posts.PostID(1), post.PostID)
+	require.Nil(t, post.PollData)
+	require.Len(t, post.Medias, 0)
+
+	// Test --dry-run
+	success, _, _ = f.TxPostsCreate(subspace, message, true, fooAddr, "--dry-run")
+	require.True(t, success)
+
+	// Test --generate-only
+	success, stdout, stderr := f.TxPostsCreate(subspace, message, true, fooAddr, "--generate-only")
+	require.Empty(t, stderr)
+	require.True(t, success)
+	msg := unmarshalStdTx(f.T, stdout)
+	require.NotZero(t, msg.Fee.Gas)
+	require.Len(t, msg.Msgs, 1)
+	require.Len(t, msg.GetSignatures(), 0)
+
+	// Check state didn't change
+	storedPosts = f.QueryPosts()
+	require.Len(t, storedPosts, 1)
+
+	f.Cleanup()
+}
+
 func TestDesmosCLIPostsCreateWithPoll(t *testing.T) {
 	t.Parallel()
 	f := InitFixtures(t)

docker-compose.yml

@@ -71,5 +71,4 @@ networks:
     ipam:
       driver: default
       config:
-        -
-          subnet: 192.168.10.0/16
+        - subnet: 192.168.10.0/16

x/posts/internal/types/msgs.go

@@ -56,8 +56,8 @@ func (msg MsgCreatePost) ValidateBasic() error {
 		return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, fmt.Sprintf("Invalid creator address: %s", msg.Creator))
 	}
 
-	if len(strings.TrimSpace(msg.Message)) == 0 {
-		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "Post message cannot be empty nor blank")
+	if len(strings.TrimSpace(msg.Message)) == 0 && len(msg.Medias) == 0 {
+		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "Post message or medias are required and cannot be both blank or empty")
 	}
 
 	if len(msg.Message) > MaxPostMessageLength {

x/posts/internal/types/msgs_test.go

@@ -75,7 +75,7 @@ func TestMsgCreatePost_ValidateBasic(t *testing.T) {
 			error: sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "Invalid creator address: "),
 		},
 		{
-			name: "Empty message returns error",
+			name: "Empty message returns error if medias and message are empty",
 			msg: types.NewMsgCreatePost(
 				"",
 				types.PostID(0),
@@ -84,10 +84,55 @@ func TestMsgCreatePost_ValidateBasic(t *testing.T) {
 				map[string]string{},
 				creator,
 				date,
+				nil,
+				msgCreatePost.PollData,
+			),
+			error: sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "Post message or medias are required and cannot be both blank or empty"),
+		},
+		{
+			name: "Non-empty message returns no error if medias are empty",
+			msg: types.NewMsgCreatePost(
+				"message",
+				types.PostID(0),
+				false,
+				"4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e",
+				map[string]string{},
+				creator,
+				date,
+				nil,
+				msgCreatePost.PollData,
+			),
+			error: nil,
+		},
+		{
+			name: "Non-empty message returns no error if medias aren't empty",
+			msg: types.NewMsgCreatePost(
+				"message",
+				types.PostID(0),
+				false,
+				"4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e",
+				map[string]string{},
+				creator,
+				date,
 				msgCreatePost.Medias,
 				msgCreatePost.PollData,
 			),
-			error: sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "Post message cannot be empty nor blank"),
+			error: nil,
+		},
+		{
+			name: "Empty message returns no error if medias aren't empty",
+			msg: types.NewMsgCreatePost(
+				"",
+				types.PostID(0),
+				false,
+				"4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e",
+				map[string]string{},
+				creator,
+				date,
+				msgCreatePost.Medias,
+				msgCreatePost.PollData,
+			),
+			error: nil,
 		},
 		{
 			name: "Very long message returns error",

x/posts/internal/types/post.go

@@ -170,8 +170,8 @@ func (p Post) Validate() error {
 		return fmt.Errorf("invalid post owner: %s", p.Creator)
 	}
 
-	if len(strings.TrimSpace(p.Message)) == 0 {
-		return fmt.Errorf("post message must be non empty and non blank")
+	if len(strings.TrimSpace(p.Message)) == 0 && len(p.Medias) == 0 {
+		return fmt.Errorf("post message or medias required, they cannot be both empty")
 	}
 
 	if len(p.Message) > MaxPostMessageLength {

x/posts/internal/types/post_test.go

@@ -255,12 +255,12 @@ func TestPost_Validate(t *testing.T) {
 			expError: "invalid post owner: ",
 		},
 		{
-			post:     types.NewPost(types.PostID(1), types.PostID(0), "", true, "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e", map[string]string{}, date, owner).WithMedias(medias).WithPollData(pollData),
-			expError: "post message must be non empty and non blank",
+			post:     types.NewPost(types.PostID(1), types.PostID(0), "", true, "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e", map[string]string{}, date, owner).WithPollData(pollData),
+			expError: "post message or medias required, they cannot be both empty",
 		},
 		{
-			post:     types.NewPost(types.PostID(1), types.PostID(0), " ", true, "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e", map[string]string{}, date, owner).WithMedias(medias).WithPollData(pollData),
-			expError: "post message must be non empty and non blank",
+			post:     types.NewPost(types.PostID(1), types.PostID(0), " ", true, "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e", map[string]string{}, date, owner).WithPollData(pollData),
+			expError: "post message or medias required, they cannot be both empty",
 		},
 		{
 			post:     types.NewPost(types.PostID(1), types.PostID(0), "Message", true, "4e188d9c17150037d5199bbdb91ae1eb2a78a15aca04cb35530cccb81494b36e", map[string]string{}, time.Time{}, owner).WithMedias(medias).WithPollData(pollData),