Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7, add 3.12 #1426

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Drop python 3.7, add 3.12 #1426

merged 7 commits into from
Oct 11, 2023

Conversation

j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Oct 7, 2023

Description

  • Drop python 3.7.
  • Add python 3.12.
  • Other housekeeping.

Blocker:

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@j-bennet j-bennet marked this pull request as draft October 7, 2023 03:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Attention: 237 lines in your changes are missing coverage. Please review.

Comparison is base (6884c29) 84.15% compared to head (a6dddda) 79.60%.
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   84.15%   79.60%   -4.56%     
==========================================
  Files          21       25       +4     
  Lines        2720     3030     +310     
==========================================
+ Hits         2289     2412     +123     
- Misses        431      618     +187     
Files Coverage Δ
pgcli/__init__.py 100.00% <100.00%> (ø)
pgcli/completion_refresher.py 91.76% <100.00%> (+1.17%) ⬆️
pgcli/packages/parseutils/__init__.py 100.00% <100.00%> (ø)
pgcli/packages/parseutils/tables.py 97.67% <ø> (ø)
pgcli/packages/prompt_utils.py 70.00% <100.00%> (+5.29%) ⬆️
pgcli/packages/sqlcompletion.py 97.67% <ø> (ø)
pgcli/pgstyle.py 64.00% <ø> (ø)
pgcli/magic.py 0.00% <0.00%> (ø)
pgcli/auth.py 91.30% <91.30%> (ø)
pgcli/key_bindings.py 52.94% <66.66%> (-0.19%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laixintao
Copy link
Member

ha, sorry missed your work on python 3.12. I closed mine: #1428

but seems the tests on 3.12 is unstable, don't know why.

from my branch, it sometimes success sometimes fail exactly like yours. (see https://github.com/dbcli/pgcli/pull/1428/commits , no code change in last 2 commit but one failed one succeed.)

@laixintao laixintao mentioned this pull request Oct 7, 2023
4 tasks
@j-bennet
Copy link
Contributor Author

j-bennet commented Oct 7, 2023

but seems the tests on 3.12 is unstable, don't know why.

from my branch, it sometimes success sometimes fail exactly like yours. (see https://github.com/dbcli/pgcli/pull/1428/commits , no code change in last 2 commit but one failed one succeed.)

Yes! I'm trying to work around that. May just have to skip it with 3.12.

@j-bennet j-bennet force-pushed the j-bennet/housekeeping branch 2 times, most recently from 816c676 to 38a0798 Compare October 8, 2023 01:07
@j-bennet j-bennet force-pushed the j-bennet/housekeeping branch from 38a0798 to a6dddda Compare October 8, 2023 01:13
@j-bennet j-bennet changed the title Drop python 3.7 Drop python 3.7, add 3.12 Oct 10, 2023
@j-bennet
Copy link
Contributor Author

@laixintao I skipped the failing checks. The build now passes. I still want to find out what's going on, but that can be done in a follow-up PR. What do you think?

@j-bennet j-bennet requested a review from laixintao October 10, 2023 18:38
@j-bennet j-bennet marked this pull request as ready for review October 10, 2023 18:38
@laixintao laixintao merged commit 6332e18 into main Oct 11, 2023
7 checks passed
@laixintao laixintao deleted the j-bennet/housekeeping branch October 11, 2023 04:35
@laixintao
Copy link
Member

Look pretty good! thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants